Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Chore] Fix autoreleasing CI job #289

Merged
merged 1 commit into from
Sep 25, 2023
Merged

[Chore] Fix autoreleasing CI job #289

merged 1 commit into from
Sep 25, 2023

Conversation

rvem
Copy link
Member

@rvem rvem commented Sep 20, 2023

Description

Problem: After a recent switch to GitHub Actions, job that creates prerelease suddenly stopped working.

Solution: Switch to the autoreleasing script from serokell.nix which uses 'gh' instead of 'hub'.

Currently based on serokell/serokell.nix#143

Proof that these changes work correctly: https://github.com/serokell/xrefcheck/actions/runs/6250135982/job/16968887140

Related issue(s)

Fixes #

✅ Checklist for your Pull Request

Ideally a PR has all of the checkmarks set.

If something in this list is irrelevant to your PR, you should still set this
checkmark indicating that you are sure it is dealt with (be that by irrelevance).

Related changes (conditional)

  • Tests

    • If I added new functionality, I added tests covering it.
    • If I fixed a bug, I added a regression test to prevent the bug from
      silently reappearing again.
  • Documentation

    • I checked whether I should update the docs and did so if necessary:
  • Public contracts

    • Any modifications of public contracts comply with the Evolution
      of Public Contracts
      policy.
    • I added an entry to the changelog if my changes are visible to the users
      and
    • provided a migration guide for breaking changes if possible

Stylistic guide (mandatory)

✓ Release Checklist

  • I updated the version number in package.yaml.
  • I updated the changelog and moved everything
    under the "Unreleased" section to a new section for this release version.
  • (After merging) I edited the auto-release.
    • Change the tag and title using the format vX.Y.Z.
    • Write a summary of all user-facing changes.
    • Deselect the "This is a pre-release" checkbox at the bottom.
  • (After merging) I updated xrefcheck-action.
  • (After merging) I uploaded the package to hackage.

@rvem rvem requested a review from a team September 20, 2023 14:54
@serokell-bot
Copy link
Contributor

serokell-bot commented Sep 20, 2023

1 Warning
⚠️ Bad issue ID in branch name.
Valid format for issue IDs: #123 or chore.

Generated by 🚫 Danger

@rvem rvem force-pushed the rvem/fix-autoreleasing branch from fa2f534 to cce9f52 Compare September 22, 2023 13:58
Problem: After a recent switch to GitHub Actions, job that creates
prerelease suddenly stopped working.

Solution: Switch to the autoreleasing script from serokell.nix
which uses 'gh' instead of 'hub'.
@rvem rvem force-pushed the rvem/fix-autoreleasing branch from cce9f52 to 8e4de7a Compare September 22, 2023 14:00
@rvem rvem merged commit d816ae7 into master Sep 25, 2023
@delete-merged-branch delete-merged-branch bot deleted the rvem/fix-autoreleasing branch September 25, 2023 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants