-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tracking Meta PR of all PRs #69
base: master
Are you sure you want to change the base?
Conversation
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 3 to 4. - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@v3...v4) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
…actions/upload-artifact-4 Bump actions/upload-artifact from 3 to 4
add --create flag
Support parallel_tests options
Add `--nice` flag
Support reading `.rspec_parallel`
Better handle interrupts
Code reviews
Handle fuubar
Use RSPEC_EXECUTABLE environmental variable if it's provided
Removed unnecessary setup code
…arallel-tests-tasks 🐛 Delay loading of parallel-tests' tasks
@ilyazub If you'd be interested in adding a maintainer, I'll apply for the role! |
@pboling Thanks for all the help! I'll review the PRs and get back you about the maintainer role. |
You can see the results of the CI on the fork here: https://github.com/VitalConnectInc/turbo_tests/actions I expect it to pass here as well, once the workflow is approved. |
@ilyazub Update: In light of the following:
I've decided to stop working on this branch. I'll leave it up for others. If the three above issues are not deal breakers for you, this branch does work quite well, and I think it would be a good starting place for further work on this gem. |
@ilyazub I think you're going to make a lot more work for yourself if you merge the other PRs individually. It was a lot of work to rebase everything to get it all working together here, and add lots of specs, and get CI passing... and now this PR is in conflict. In case it wasn't clear, I carefully retained the "authorship" of the original commiters, so merging this does make them all contributors. |
@ilyazub FWIW, the PRs I made against my repo where I rebased the original PRs against your repo, are all linked as the nested bullets in the OP description. If you want to use those to individually merge things, it would be easiest if you did them in order, since otherwise the rebasing will get out of sync. |
Update: I was in the process of upgrading, improving, rebasing, & merging all PRs on this repo against my tracking repo.
However, in light of the following:
I've decided to stop working on this branch. I'll leave it up for others. If the three above issues are not deal breakers for you, this branch does work quite well, and I think it would be a good starting place for @ilyazub to further modernize this gem.
--nice
flag #44--nice
flag VitalConnectInc/turbo_tests#5.rspec_parallel
#45.rspec_parallel
VitalConnectInc/turbo_tests#6