Centralize use from getEventsByResourceId applying DRY (secultce#628)

sertao-dev · Jan 28, 2025 · 7b63d15 · 7b63d15
1 parent bcaed0c
commit 7b63d15
Show file tree

Hide file tree

Showing 10 changed files with 39 additions and 111 deletions.
diff --git a/src/DocumentService/AbstractTimelineDocumentService.php b/src/DocumentService/AbstractTimelineDocumentService.php
@@ -4,21 +4,31 @@
 
 namespace App\DocumentService;
 
+use App\DocumentService\Interface\TimelineDocumentServiceInterface;
 use Doctrine\ODM\MongoDB\DocumentManager;
+use Doctrine\ODM\MongoDB\Repository\DocumentRepository;
+use Symfony\Component\Uid\Uuid;
 
-abstract class AbstractTimelineDocumentService
+abstract class AbstractTimelineDocumentService implements TimelineDocumentServiceInterface
 {
     public const string CREATED = 'The resource was created';
     public const string DELETED = 'The resource was deleted';
     public const string UPDATED = 'The resource was updated';
+    protected DocumentRepository $documentRepository;
 
     public function __construct(
-        private DocumentManager $documentManager,
+        private readonly DocumentManager $documentManager,
+        private readonly string $documentClass
     ) {
+        $this->documentRepository = $this->documentManager->getRepository(
+            $this->documentClass
+        );
     }
 
-    public function getDocumentManager(): DocumentManager
+    public function getEventsByEntityId(Uuid $id): array
     {
-        return $this->documentManager;
+        return $this->documentRepository->findBy([
+            'resourceId' => $id,
+        ]);
     }
 }
diff --git a/src/DocumentService/AgentTimelineDocumentService.php b/src/DocumentService/AgentTimelineDocumentService.php
@@ -6,22 +6,12 @@
 
 use App\Document\AgentTimeline;
 use App\DocumentService\Interface\TimelineDocumentServiceInterface;
-use Doctrine\ODM\MongoDB\Repository\DocumentRepository;
-use Symfony\Component\Uid\Uuid;
+use Doctrine\ODM\MongoDB\DocumentManager;
 
 final class AgentTimelineDocumentService extends AbstractTimelineDocumentService implements TimelineDocumentServiceInterface
 {
-    public function getDocumentRepository(): DocumentRepository
+    public function __construct(DocumentManager $documentManager)
     {
-        return $this
-            ->getDocumentManager()
-            ->getRepository(AgentTimeline::class);
-    }
-
-    public function getEventsByEntityId(Uuid $id): array
-    {
-        return $this->getDocumentRepository()->findBy([
-            'resourceId' => $id,
-        ]);
+        parent::__construct($documentManager, AgentTimeline::class);
     }
 }
diff --git a/src/DocumentService/EventTimelineDocumentService.php b/src/DocumentService/EventTimelineDocumentService.php
@@ -6,22 +6,12 @@
 
 use App\Document\EventTimeline;
 use App\DocumentService\Interface\TimelineDocumentServiceInterface;
-use Doctrine\ODM\MongoDB\Repository\DocumentRepository;
-use Symfony\Component\Uid\Uuid;
+use Doctrine\ODM\MongoDB\DocumentManager;
 
 final class EventTimelineDocumentService extends AbstractTimelineDocumentService implements TimelineDocumentServiceInterface
 {
-    public function getDocumentRepository(): DocumentRepository
+    public function __construct(DocumentManager $documentManager)
     {
-        return $this
-            ->getDocumentManager()
-            ->getRepository(EventTimeline::class);
-    }
-
-    public function getEventsByEntityId(Uuid $id): array
-    {
-        return $this->getDocumentRepository()->findBy([
-            'resourceId' => $id,
-        ]);
+        parent::__construct($documentManager, EventTimeline::class);
     }
 }
diff --git a/src/DocumentService/InitiativeTimelineDocumentService.php b/src/DocumentService/InitiativeTimelineDocumentService.php
@@ -6,22 +6,12 @@
 
 use App\Document\InitiativeTimeline;
 use App\DocumentService\Interface\TimelineDocumentServiceInterface;
-use Doctrine\ODM\MongoDB\Repository\DocumentRepository;
-use Symfony\Component\Uid\Uuid;
+use Doctrine\ODM\MongoDB\DocumentManager;
 
 final class InitiativeTimelineDocumentService extends AbstractTimelineDocumentService implements TimelineDocumentServiceInterface
 {
-    public function getDocumentRepository(): DocumentRepository
+    public function __construct(DocumentManager $documentManager)
     {
-        return $this
-            ->getDocumentManager()
-            ->getRepository(InitiativeTimeline::class);
-    }
-
-    public function getEventsByEntityId(Uuid $id): array
-    {
-        return $this->getDocumentRepository()->findBy([
-            'resourceId' => $id,
-        ]);
+        parent::__construct($documentManager, InitiativeTimeline::class);
     }
 }
diff --git a/src/DocumentService/Interface/TimelineDocumentServiceInterface.php b/src/DocumentService/Interface/TimelineDocumentServiceInterface.php
@@ -4,12 +4,9 @@
 
 namespace App\DocumentService\Interface;
 
-use Doctrine\ODM\MongoDB\Repository\DocumentRepository;
 use Symfony\Component\Uid\Uuid;
 
 interface TimelineDocumentServiceInterface
 {
-    public function getDocumentRepository(): DocumentRepository;
-
     public function getEventsByEntityId(Uuid $id): array;
 }
diff --git a/src/DocumentService/OpportunityTimelineDocumentService.php b/src/DocumentService/OpportunityTimelineDocumentService.php
@@ -6,22 +6,12 @@
 
 use App\Document\OpportunityTimeline;
 use App\DocumentService\Interface\TimelineDocumentServiceInterface;
-use Doctrine\ODM\MongoDB\Repository\DocumentRepository;
-use Symfony\Component\Uid\Uuid;
+use Doctrine\ODM\MongoDB\DocumentManager;
 
 final class OpportunityTimelineDocumentService extends AbstractTimelineDocumentService implements TimelineDocumentServiceInterface
 {
-    public function getDocumentRepository(): DocumentRepository
+    public function __construct(DocumentManager $documentManager)
     {
-        return $this
-            ->getDocumentManager()
-            ->getRepository(OpportunityTimeline::class);
-    }
-
-    public function getEventsByEntityId(Uuid $id): array
-    {
-        return $this->getDocumentRepository()->findBy([
-            'resourceId' => $id,
-        ]);
+        parent::__construct($documentManager, OpportunityTimeline::class);
     }
 }
diff --git a/src/DocumentService/OrganizationTimelineDocumentService.php b/src/DocumentService/OrganizationTimelineDocumentService.php
@@ -6,22 +6,12 @@
 
 use App\Document\OrganizationTimeline;
 use App\DocumentService\Interface\TimelineDocumentServiceInterface;
-use Doctrine\ODM\MongoDB\Repository\DocumentRepository;
-use Symfony\Component\Uid\Uuid;
+use Doctrine\ODM\MongoDB\DocumentManager;
 
 final class OrganizationTimelineDocumentService extends AbstractTimelineDocumentService implements TimelineDocumentServiceInterface
 {
-    public function getDocumentRepository(): DocumentRepository
+    public function __construct(DocumentManager $documentManager)
     {
-        return $this
-            ->getDocumentManager()
-            ->getRepository(OrganizationTimeline::class);
-    }
-
-    public function getEventsByEntityId(Uuid $id): array
-    {
-        return $this->getDocumentRepository()->findBy([
-            'resourceId' => $id,
-        ]);
+        parent::__construct($documentManager, OrganizationTimeline::class);
     }
 }
diff --git a/src/DocumentService/PhaseTimelineDocumentService.php b/src/DocumentService/PhaseTimelineDocumentService.php
@@ -6,22 +6,12 @@
 
 use App\Document\PhaseTimeline;
 use App\DocumentService\Interface\TimelineDocumentServiceInterface;
-use Doctrine\ODM\MongoDB\Repository\DocumentRepository;
-use Symfony\Component\Uid\Uuid;
+use Doctrine\ODM\MongoDB\DocumentManager;
 
 final class PhaseTimelineDocumentService extends AbstractTimelineDocumentService implements TimelineDocumentServiceInterface
 {
-    public function getDocumentRepository(): DocumentRepository
+    public function __construct(DocumentManager $documentManager)
     {
-        return $this
-            ->getDocumentManager()
-            ->getRepository(PhaseTimeline::class);
-    }
-
-    public function getEventsByEntityId(Uuid $id): array
-    {
-        return $this->getDocumentRepository()->findBy([
-            'resourceId' => $id,
-        ]);
+        parent::__construct($documentManager, PhaseTimeline::class);
     }
 }
diff --git a/src/DocumentService/SpaceTimelineDocumentService.php b/src/DocumentService/SpaceTimelineDocumentService.php
@@ -6,22 +6,12 @@
 
 use App\Document\SpaceTimeline;
 use App\DocumentService\Interface\TimelineDocumentServiceInterface;
-use Doctrine\ODM\MongoDB\Repository\DocumentRepository;
-use Symfony\Component\Uid\Uuid;
+use Doctrine\ODM\MongoDB\DocumentManager;
 
 final class SpaceTimelineDocumentService extends AbstractTimelineDocumentService implements TimelineDocumentServiceInterface
 {
-    public function getDocumentRepository(): DocumentRepository
+    public function __construct(DocumentManager $documentManager)
     {
-        return $this
-            ->getDocumentManager()
-            ->getRepository(SpaceTimeline::class);
-    }
-
-    public function getEventsByEntityId(Uuid $id): array
-    {
-        return $this->getDocumentRepository()->findBy([
-            'resourceId' => $id,
-        ]);
+        parent::__construct($documentManager, SpaceTimeline::class);
     }
 }
diff --git a/src/DocumentService/UserTimelineDocumentService.php b/src/DocumentService/UserTimelineDocumentService.php
@@ -7,28 +7,19 @@
 use App\Document\UserTimeline;
 use App\DocumentService\Interface\TimelineDocumentServiceInterface;
 use DateTime;
-use Doctrine\ODM\MongoDB\Repository\DocumentRepository;
+use Doctrine\ODM\MongoDB\DocumentManager;
 use Symfony\Component\Uid\Uuid;
 
 final class UserTimelineDocumentService extends AbstractTimelineDocumentService implements TimelineDocumentServiceInterface
 {
-    public function getDocumentRepository(): DocumentRepository
+    public function __construct(DocumentManager $documentManager)
     {
-        return $this
-            ->getDocumentManager()
-            ->getRepository(UserTimeline::class);
-    }
-
-    public function getEventsByEntityId(Uuid $id): array
-    {
-        return $this->getDocumentRepository()->findBy([
-            'resourceId' => $id,
-        ]);
+        parent::__construct($documentManager, UserTimeline::class);
     }
 
     public function getLastLoginByUserId(Uuid $id): ?DateTime
     {
-        $lastLogin = $this->getDocumentRepository()->findOneBy(
+        $lastLogin = $this->documentRepository->findOneBy(
             [
                 'resourceId' => $id,
                 'action' => 'login',