Skip to content

Conversation

@nielsenko
Copy link
Collaborator

@nielsenko nielsenko commented Oct 24, 2025

Bump, format, and use new _ parameter (no longer an actual variable).

Fixes: #237

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 24, 2025

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Oct 27, 2025

Codecov Report

❌ Patch coverage is 95.71984% with 22 lines in your changes missing coverage. Please review.
✅ Project coverage is 91.41%. Comparing base (3ab7119) to head (6143085).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
lib/src/message/response.dart 75.00% 6 Missing ⚠️
lib/src/adapter/io/io_relic_web_socket.dart 77.77% 2 Missing ⚠️
lib/src/io/static/static_handler.dart 95.74% 2 Missing ⚠️
lib/src/middleware/middleware_logger.dart 84.61% 2 Missing ⚠️
lib/src/relic_server.dart 90.47% 2 Missing ⚠️
...c/headers/typed/headers/authentication_header.dart 91.66% 1 Missing ⚠️
...rc/headers/typed/headers/authorization_header.dart 93.75% 1 Missing ⚠️
...ib/src/headers/typed/headers/forwarded_header.dart 95.45% 1 Missing ⚠️
...eaders/typed/headers/permission_policy_header.dart 94.73% 1 Missing ⚠️
lib/src/io/static/cache_busting_config.dart 80.00% 1 Missing ⚠️
... and 3 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #239      +/-   ##
==========================================
+ Coverage   91.33%   91.41%   +0.07%     
==========================================
  Files          89       89              
  Lines        3428     3458      +30     
  Branches     1763     1763              
==========================================
+ Hits         3131     3161      +30     
  Misses        297      297              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@nielsenko nielsenko force-pushed the upgrade-sdk-3.7 branch 9 times, most recently from b6996f5 to ef2f454 Compare October 28, 2025 11:25
@nielsenko nielsenko marked this pull request as ready for review October 28, 2025 11:37
@nielsenko nielsenko requested a review from SandPod October 28, 2025 11:37
Copy link
Contributor

@SandPod SandPod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@nielsenko nielsenko merged commit a36d5fc into serverpod:main Oct 28, 2025
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Flaky Windows CI: Coverage collection intermittently fails

2 participants