Skip to content
This repository has been archived by the owner on Oct 20, 2023. It is now read-only.

FOSSA workflow added #86

Merged

Conversation

idvoretskyi
Copy link
Contributor

Fixes servicemeshinterface/smi-spec#183

Signed-off-by: Ihor Dvoretskyi [email protected]

Signed-off-by: Ihor Dvoretskyi <[email protected]>
@idvoretskyi
Copy link
Contributor Author

It's unclear to me now what causes an issue - https://github.com/servicemeshinterface/smi-sdk-go/pull/86/checks?check_run_id=976150974#step:5:22; in touch with the FOSSA team on debugging.

@idvoretskyi
Copy link
Contributor Author

@stefanprodan PTAL, looks good now.

@stefanprodan
Copy link
Contributor

The URL to the report returns a 404

@idvoretskyi
Copy link
Contributor Author

@stefanprodan fixed, thanks for pointing out.

@stefanprodan
Copy link
Contributor

Screenshot 2020-08-14 at 10 22 45

@idvoretskyi I can't access the report even if I'm a maintainer of the SDK and I did login with GitHub.

@idvoretskyi
Copy link
Contributor Author

@stefanprodan if you'll scroll down, you'll see the full public report.

In addition, I'm trying to invite you and other project maintainers to the FOSSA UI to get the maintainers access, but this part of UI doesn't seem to be working (reported to FOSSA).

However, the full report is already r/o available so I think we can proceed with merging this now. I'll work on granting you the full r/w access separately.

@idvoretskyi
Copy link
Contributor Author

@stefanprodan your access should be fixed now, please check. If all good, I'll proceed with adding other project maintainers to the org.

Copy link
Contributor

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @idvoretskyi

@idvoretskyi
Copy link
Contributor Author

@stefanprodan anything else is needed to get this merged?

@idvoretskyi
Copy link
Contributor Author

Ref - cncf/foundation#109

@stefanprodan
Copy link
Contributor

stefanprodan commented Sep 1, 2020

Hey @idvoretskyi I was on PTO, I'll merge the FOSSA PRs now, looks ok thank you!

@stefanprodan stefanprodan merged commit c39d909 into servicemeshinterface:master Sep 1, 2020
@idvoretskyi
Copy link
Contributor Author

@stefanprodan thanks!

@idvoretskyi idvoretskyi deleted the idvoretskyi-fossa branch September 1, 2020 16:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deploy FOSSA license scanning
2 participants