-
Notifications
You must be signed in to change notification settings - Fork 39
FOSSA workflow added #86
FOSSA workflow added #86
Conversation
Signed-off-by: Ihor Dvoretskyi <[email protected]>
It's unclear to me now what causes an issue - https://github.com/servicemeshinterface/smi-sdk-go/pull/86/checks?check_run_id=976150974#step:5:22; in touch with the FOSSA team on debugging. |
https://github.com/fossas/fossa-cli/blob/master/docs/integrations/golang.md#automatic Signed-off-by: Ihor Dvoretskyi <[email protected]>
@stefanprodan PTAL, looks good now. |
The URL to the report returns a 404 |
@stefanprodan fixed, thanks for pointing out. |
@idvoretskyi I can't access the report even if I'm a maintainer of the SDK and I did login with GitHub. |
@stefanprodan if you'll scroll down, you'll see the full public report. In addition, I'm trying to invite you and other project maintainers to the FOSSA UI to get the maintainers access, but this part of UI doesn't seem to be working (reported to FOSSA). However, the full report is already r/o available so I think we can proceed with merging this now. I'll work on granting you the full r/w access separately. |
@stefanprodan your access should be fixed now, please check. If all good, I'll proceed with adding other project maintainers to the org. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks @idvoretskyi
@stefanprodan anything else is needed to get this merged? |
Ref - cncf/foundation#109 |
Hey @idvoretskyi I was on PTO, I'll merge the FOSSA PRs now, looks ok thank you! |
@stefanprodan thanks! |
Fixes servicemeshinterface/smi-spec#183
Signed-off-by: Ihor Dvoretskyi [email protected]