Skip to content
This repository has been archived by the owner on Oct 20, 2023. It is now read-only.

Sidecar or Monitor? I chose Sidecar #1

Closed
wants to merge 2 commits into from

Conversation

craiglpeters
Copy link
Collaborator

Sidecar is used in the specification (in one place, but not another). I like the sidecar approach because it is general enough to handle almost everything, and monitoring isn't the only function that might need to be implemented. The downside is that it can be abused, but that won't be the specification's fault.

Sidecar is used in the specification (in one place, but not another). I like the sidecar approach because it is general enough to handle almost everything, and monitoring isn't the only function that might need to be implemented. The downside is that it can be abused, but that won't be the specification's fault.
@brendandburns
Copy link
Collaborator

cc @gabrtv thoughts?

@gabrtv
Copy link
Collaborator

gabrtv commented Mar 28, 2019

I don't feel strongly but I lean Sidecar. Sidecar is less purist from a resource modeling perspective, but it'll allow us to evolve more sidecar management capabilities as @craiglpeters suggests.

@squillace
Copy link

FWIW, I like the sidecar approach when you own everything, so that you can manage sidecars with transparency. With multiple sidecars potentially used in same environment, I like Gabe's words: evolve more sidecar management capabilities. They'll be needed. sidecars are the electron of the kube world.

@nisheethsrivastava
Copy link
Collaborator

Sidecar is very generic mechanism to implement many abilities, including mTLS and Monitor. If we go with sidecar, then we are losing the context in which the API spec specifies the purpose of this side car. It might be better to specify the ability we want in API as opposed to how it should be implemented.

@slack
Copy link
Collaborator

slack commented May 6, 2019

Closing this PR, we've moved to TrafficMetrics over Sidecar/Monitor.

@slack slack closed this May 6, 2019
@michelleN michelleN deleted the craiglpeters-review branch August 18, 2021 16:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants