This repository has been archived by the owner on Oct 20, 2023. It is now read-only.
ref(TrafficTarget): update requirements for TrafficTarget #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michelleN
requested review from
bridgetkromhout,
grampelberg,
ilevine,
lachie83,
leecalcote,
nicholasjackson,
slack and
stefanprodan
as code owners
michelleN
force-pushed
the
target-no-rule
branch
4 times, most recently
from
7754a29 to
bed59f1
Compare
stefanprodan
previously approved these changes
Oct 1, 2020
michelleN
force-pushed
the
target-no-rule
branch
from
bed59f1 to
e99b011
Compare
|
@michelleN can you please fix: |
stefanprodan
previously approved these changes
Oct 14, 2020
Signed-off-by: Michelle Noorali <[email protected]>
michelleN
force-pushed
the
target-no-rule
branch
from
e99b011 to
2e52af4
Compare
lachie83
approved these changes
Dec 7, 2020
bridgetkromhout
approved these changes
Dec 7, 2020
|
Looks like this clarifies it - thanks, @michelleN! |
|
This must makes much sense. This statement reinforces that there are three required elements of what comprises a TrafficTarget. ✔️ |
leecalcote
approved these changes
Dec 8, 2020
stefanprodan
approved these changes
Dec 8, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #188
Slack thread: https://cloud-native.slack.com/archives/C0105GB1BJQ/p1600760173001900