Skip to content
This repository has been archived by the owner on Oct 20, 2023. It is now read-only.

Update apiVersion #21

Merged
merged 4 commits into from
May 6, 2019
Merged

Update apiVersion #21

merged 4 commits into from
May 6, 2019

Conversation

grampelberg
Copy link
Collaborator

I've gone through and updated all the apiVersions. While doing it, I realized that it is probably valuable to version each of these apis differently (so that it isn't quite a big of a bang to push the version forward). This suggests that idea that each major API has its own namespace and can version independently.

traffic-split.md Outdated Show resolved Hide resolved
@alban
Copy link
Contributor

alban commented May 3, 2019

Thanks! I will update smi-adapter-istio to pick up the new name once this is merged.

There was a discussion to change v1beta1 to v1alpha1. Do we keep the "beta" names in the end?

Co-Authored-By: grampelberg <[email protected]>
@grampelberg
Copy link
Collaborator Author

@alban I don't have a preference on v1beta1 vs v1alpha1, what do you think?

@alban
Copy link
Contributor

alban commented May 6, 2019

@grampelberg I would start with v1alpha1 since we are not yet at the point of providing instructions for migration between different versions of the API:

https://kubernetes.io/docs/concepts/overview/kubernetes-api/#api-versioning

Alpha level:
The API may change in incompatible ways in a later software release without notice.
Beta level:
The schema and/or semantics of objects may change in incompatible ways in a subsequent beta or stable release. When this happens, we will provide instructions for migrating to the next version.

@grampelberg
Copy link
Collaborator Author

@alban great call. I'll merge for now, as always if anyone has issues we can get them fixed in a follow up PR.

@grampelberg grampelberg merged commit 4691211 into master May 6, 2019
@grampelberg grampelberg deleted the grampelberg/update-apiversion branch May 6, 2019 15:37
@surajssd surajssd mentioned this pull request May 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants