This repository has been archived by the owner on Oct 20, 2023. It is now read-only.
Rename TrafficTarget to TrafficAccess. #226
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnsonshi
requested review from
bridgetkromhout,
grampelberg,
ilevine,
lachie83,
leecalcote,
mhausenblas,
michelleN,
nicholasjackson,
Pothulapati,
slack and
stefanprodan
as code owners
michelleN
suggested changes
Aug 4, 2021
There was a problem hiding this comment.
@johnsonshi Could you use git mv to move the traffic target spec file to the new path and then modify the file to rename traffic target to traffic access? This will preserve the author history of the spec file.
Renames the TrafficTarget traffic access api to TrafficAccess to increase clarity. Bumps traffic access version to v1alpha4. Resolves #177. Signed-off-by: Johnson Shi <[email protected]>
Renames the TrafficTarget traffic access api to TrafficAccess to increase clarity. Bumps traffic access version to v1alpha4. Resolves #177. Signed-off-by: Johnson Shi <[email protected]>
Signed-off-by: Johnson Shi <[email protected]>
|
Back from oof @michelleN! Performed |
stefanprodan
previously approved these changes
Sep 9, 2021
johnsonshi
dismissed
stefanprodan’s stale review
The base branch was changed.
Renames the TrafficTarget traffic access api to TrafficAccess to increase clarity. Bumps traffic access version to v1alpha4. Resolves #177. Signed-off-by: Johnson Shi <[email protected]>
michelleN
suggested changes
Sep 13, 2021
Signed-off-by: Johnson Shi <[email protected]>
Signed-off-by: Johnson Shi <[email protected]>
Signed-off-by: Johnson Shi <[email protected]>
michelleN
approved these changes
Sep 28, 2021
michelleN
suggested changes
Sep 28, 2021
There was a problem hiding this comment.
The matches keys in the traffic specs yaml should be routes. Check out the latest traffic specs document https://github.com/servicemeshinterface/smi-spec/blob/draft/apis/traffic-specs/traffic-specs.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renames the TrafficTarget traffic access api to
TrafficAccess to increase clarity.
Bumps traffic access version to v1alpha4.
Resolves #177.
Signed-off-by: Johnson Shi [email protected]