Skip to content
This repository has been archived by the owner on Oct 20, 2023. It is now read-only.

docs: type of headers hould be object instead array #237

Merged
merged 1 commit into from
Jan 12, 2022
Merged

docs: type of headers hould be object instead array #237

merged 1 commit into from
Jan 12, 2022

Conversation

tokers
Copy link
Contributor

@tokers tokers commented Sep 30, 2021

Signed-off-by: Chao Zhang [email protected]

@tokers tokers mentioned this pull request Oct 1, 2021
Closed
@tokers
Copy link
Contributor Author

tokers commented Oct 9, 2021

Any noise?

stefanprodan
stefanprodan approved these changes Dec 2, 2021
View reviewed changes
Copy link
Contributor

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @tokers 🏅

leecalcote
leecalcote approved these changes Dec 8, 2021
View reviewed changes
Copy link
Member

@leecalcote leecalcote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. Good stuff here, @tokers. Thank you.

@bridgetkromhout bridgetkromhout merged commit ea46b9b into servicemeshinterface:main Jan 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@leecalcote leecalcote leecalcote approved these changes

@stefanprodan stefanprodan stefanprodan approved these changes

@bridgetkromhout bridgetkromhout Awaiting requested review from bridgetkromhout bridgetkromhout is a code owner

@grampelberg grampelberg Awaiting requested review from grampelberg grampelberg is a code owner

@ilevine ilevine Awaiting requested review from ilevine ilevine is a code owner

@lachie83 lachie83 Awaiting requested review from lachie83 lachie83 is a code owner

@mhausenblas mhausenblas Awaiting requested review from mhausenblas mhausenblas is a code owner

@michelleN michelleN Awaiting requested review from michelleN

@nicholasjackson nicholasjackson Awaiting requested review from nicholasjackson nicholasjackson is a code owner

@Pothulapati Pothulapati Awaiting requested review from Pothulapati Pothulapati is a code owner

@slack slack Awaiting requested review from slack slack is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tokers @stefanprodan @leecalcote @bridgetkromhout