Skip to content
This repository has been archived by the owner on Oct 20, 2023. It is now read-only.

Add an example to Canary. #5

Merged
merged 1 commit into from
Apr 12, 2019

Conversation

brendandburns
Copy link
Collaborator

Copy link
Collaborator

@grampelberg grampelberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me. You've got me thinking about whether this is usable for the ingress controllers as well now. Moving the canary definitions out of random annotations to a real resource would be a large improvement.

@slack
Copy link
Collaborator

slack commented Apr 10, 2019

The decoupling is nice, and having explicit Canary resources is great.

For customers to "start" a canary though, wouldn't all clients of the service need to be re-deployed to use the new "canaryable" service name? Is that a non-starter?

@grampelberg
Copy link
Collaborator

@slack it really depends on how you're doing the integration. You could just take over the root service and switch its labels around, copying them down to one of the leaf services. That would maintain this crazy simple/awesome implementation.

From the Linkerd side of things, we don't need to do any of that because the sidecar is already on the client side and the sample workflow should work, including fallback for non-mesh traffic.

@slack
Copy link
Collaborator

slack commented Apr 12, 2019

@grampelberg seems reasonable. Let's merge this and the follow up with the rename in #8

@slack slack merged commit 9a4c605 into servicemeshinterface:master Apr 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants