Add SMI spec integration - service mesh hub #57
Conversation
Page to explain service mesh hub, a reference implementation of SMI spec, how to try it and links to more information on Hub
bettyjunod
requested review from
alban,
brendandburns,
gabrtv,
grampelberg,
lachie83,
leecalcote,
nicholasjackson,
slack,
stefanprodan and
surajssd
as code owners
|
|
There was a problem hiding this comment.
Couple requests:
- Please make this match the other documents (all lower case, markdown, service-mesh-hub.md for example).
- I know we don't have CI running here yet, but it would be awesome if you passed this through markdownlint.
- Please add a section and link for this from README.md so that it shows up on the main page!
As a high level, will service mesh hub become part of SMI? We'll need to think about how to message third party solutions if that's not the case.
Example-ServiceMeshHub
Outdated
|
|
||
| ##Instructions to install Service Mesh Hub## | ||
| Install Service Mesh Hub on your kubernetes cluster by running the following command: | ||
| ``` |
There was a problem hiding this comment.
It'd be great to add language to these (bash) and remove the $.
Example-ServiceMeshHub
Outdated
|
|
||
| The Service Mesh Hub is a mesh agnostic dashboard that implements the SMI specification for users to install and operate meshes. A read only version of the Service Mesh Hub can be found on https://servicemeshhub.io | ||
|
|
||
| Service Mesh Hub does |
There was a problem hiding this comment.
Service Mesh Hub does:
Example-ServiceMeshHub
Outdated
| $ kubectl port-forward -n sm-marketplace deploy/smm-apiserver 8080 | ||
| ``` | ||
|
|
||
| Then navigate your browser to: |
There was a problem hiding this comment.
Then navigate your browser to localhost:8080.
Example-ServiceMeshHub
Outdated
| Then navigate your browser to: | ||
| ```localhost:8080``` | ||
|
|
||
|
|
There was a problem hiding this comment.
Navigate to Extensions tab and install the SMI Spec extension
http://servicemeshhub.io/extensions/default/smi
|
@grampelberg not so much that Hub becomes a part of SMI but it is an example implementation. Maybe we should consider making an Examples folder so that others in the ecosystem can put in there...WDYT |
addressed comments and made edits removed authoring extensions added installing the SMI extension
|
Hmm, couple comments:
|
|
@grampelberg for now are we good if I rename from "example" to "integration" |
|
@bettyjunod |
bettyjunod
changed the title
|
@grampelberg which markdown issues? I need a little help here -- can take to slack if that's easier for chatting |
|
@bettyjunod just that it won't pass lint. It looks like there hasn't been a run yet though, mind pushing a new commit to kick CI off? It should give you all the issues there. |
|
/kick |
|
While we're waiting for one more reviewer, let's consider getting this linked from somewhere as well. |
Page to explain service mesh hub, a reference implementation of SMI spec, how to try it and links to more information on Hub