Skip to content
This repository was archived by the owner on Oct 20, 2023. It is now read-only.

Flesh out traffic metrics API#7

Merged
grampelberg merged 2 commits intoservicemeshinterface:masterfrom
grampelberg:grampelberg/metrics
Apr 18, 2019
Merged

Flesh out traffic metrics API#7
grampelberg merged 2 commits intoservicemeshinterface:masterfrom
grampelberg:grampelberg/metrics

Conversation

@grampelberg
Copy link
Copy Markdown
Collaborator

No description provided.

@grampelberg grampelberg force-pushed the grampelberg/metrics branch from ea1d251 to 12ca319 Compare April 17, 2019 00:14
@grampelberg
Copy link
Copy Markdown
Collaborator Author

Updated with an example implementation!

@nicholasjackson
Copy link
Copy Markdown
Collaborator

nicholasjackson commented Apr 17, 2019

Hey @grampelberg, I like where this is going. I am thinking though we still need the original Monitoring spec. I wonder if the metrics API should be broken out into a separate spec?

Sent you an email, be good to chat to you in depth about this and other spec things.

Comment thread specification.md
blank `edge.resource` would have metrics for all the traffic received by
`resource`.

Edges are only visible between two resources that have exchanged traffic. They
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I worry a little about this, because what if I have an error and no traffic is flowing, but there should be. How can I monitor/discover this?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, how would we know that the edge exists without traffic? Users could define the edges they'd expect for an application, in my experience folks just don't know though =/

@brendandburns
Copy link
Copy Markdown
Collaborator

@grampelberg this looks like a great direction from my perspective. Do we think we're ready to merge and iterate or is there more discussion needed on this?

@grampelberg
Copy link
Copy Markdown
Collaborator Author

@brendandburns merge away! What do you feel is the next iteration?

@grampelberg
Copy link
Copy Markdown
Collaborator Author

I'm going to merge this, happy to back it out if folks have issues (trying to avoid conflicts on the policy stuff).

@grampelberg grampelberg merged commit 8285bd9 into servicemeshinterface:master Apr 18, 2019
@grampelberg grampelberg deleted the grampelberg/metrics branch April 18, 2019 20:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants