Flesh out traffic metrics API#7
Conversation
ea1d251 to
12ca319
Compare
|
Updated with an example implementation! |
|
Hey @grampelberg, I like where this is going. I am thinking though we still need the original Monitoring spec. I wonder if the metrics API should be broken out into a separate spec? Sent you an email, be good to chat to you in depth about this and other spec things. |
| blank `edge.resource` would have metrics for all the traffic received by | ||
| `resource`. | ||
|
|
||
| Edges are only visible between two resources that have exchanged traffic. They |
There was a problem hiding this comment.
I worry a little about this, because what if I have an error and no traffic is flowing, but there should be. How can I monitor/discover this?
There was a problem hiding this comment.
Agreed, how would we know that the edge exists without traffic? Users could define the edges they'd expect for an application, in my experience folks just don't know though =/
|
@grampelberg this looks like a great direction from my perspective. Do we think we're ready to merge and iterate or is there more discussion needed on this? |
|
@brendandburns merge away! What do you feel is the next iteration? |
|
I'm going to merge this, happy to back it out if folks have issues (trying to avoid conflicts on the policy stuff). |
No description provided.