Skip to content
This repository has been archived by the owner on Oct 20, 2023. It is now read-only.

update/add versions to specs #81

Merged
merged 1 commit into from
Nov 18, 2019
Merged

update/add versions to specs #81

merged 1 commit into from
Nov 18, 2019

Conversation

michelleN
Copy link
Contributor

resolves #68

@grampelberg
Copy link
Collaborator

Anyone up for another review? @nicholasjackson perhaps? It'd be great to get this merged.

leecalcote
leecalcote approved these changes Nov 1, 2019
View reviewed changes
Copy link
Member

@leecalcote leecalcote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No bones to pick here. LGTM

stefanprodan
stefanprodan approved these changes Nov 1, 2019
View reviewed changes
Copy link
Contributor

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@asridharan
Copy link

@michelleN just a thought. Might be a good idea to add some description here as to how the individual spec versions are going to progress, else it might confuse folks who join a late.

Currently it looks like we are progressing with v1aplha1 -> v1alpha2 and GA would be v1. So how would we go about bumping up the version here?

@michelleN
Copy link
Contributor Author

@asridharan - great point. I can add a section about versioning to the README. Each spec/CRD has a version associated with it. We'll go from v1alpha# to v1beta# then v1 like you described. Would adding that info to the README be sufficient or are you suggesting something else?

grampelberg
grampelberg approved these changes Nov 18, 2019
View reviewed changes
Copy link
Collaborator

@grampelberg grampelberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@grampelberg grampelberg merged commit 1349168 into servicemeshinterface:master Nov 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rickducott rickducott rickducott approved these changes

@leecalcote leecalcote leecalcote approved these changes

@stefanprodan stefanprodan stefanprodan approved these changes

@grampelberg grampelberg grampelberg approved these changes

@alban alban Awaiting requested review from alban

@brendandburns brendandburns Awaiting requested review from brendandburns

@gabrtv gabrtv Awaiting requested review from gabrtv

@lachie83 lachie83 Awaiting requested review from lachie83

@nicholasjackson nicholasjackson Awaiting requested review from nicholasjackson

@slack slack Awaiting requested review from slack

@surajssd surajssd Awaiting requested review from surajssd

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

versioning the spec
6 participants
@michelleN @grampelberg @asridharan @stefanprodan @leecalcote @rickducott