Repository navigation
Use cargo-ohos to build for OpenHarmony with LLVM-19 - #796
Conversation
|
BTW Rust 1.88 (so the MSRV) uses clang 20, because I know you are interested in LTO.
Yeah, I am not sure why did not try that in the first place. |
I'm going with clang-19 for now mainly because that's an official prebuilt "preview" version I found. It seems like compiling clang-20 from source with ohos support also works, so I might build / host that myself after some more investigation. |
ddd558e to
d75f406
Compare
In preparation for the upcoming ESR-153, switch to using `cargo-ohos` instead of our custom script. Supporting a non-SDK LLVM ends up being quite a bit more complex, and needing to duplicate that logic across every project that needs to build for ohos doesn't make sense. Hence, use cargo-ohos to wrap all the environment variables, and toolchain downloading etc. for an openharmony build. For android it might also make sense to switch to cargo-ndk, instead of rolling our own script, but thats another topic. Signed-off-by: Jonathan Schwender <schwenderjonathan@gmail.com>
Signed-off-by: Jonathan Schwender <schwenderjonathan@gmail.com>
Signed-off-by: Jonathan Schwender <schwenderjonathan@gmail.com>
d75f406 to
fc6dccf
Compare
|
Any reason for not landing this yet? |
|
The companion PR isn't approved yet, and ideally both should land at the same time (since the precompiled artifact with clang-19 wouldn't work with servo-main as of now). |
In preparation for the upcoming ESR-153, switch to using
cargo-ohosinstead of our custom script.Supporting a non-SDK LLVM ends up being quite a bit more complex, and needing to duplicate that logic across every project that needs to build for ohos doesn't make sense. Hence, use cargo-ohos to wrap all the environment variables, and toolchain downloading etc. for an openharmony build.
Testing: Covered by existing tests in servo
Servo PR: servo/servo#47421