Repository navigation
Add safe variants of throw_internal_error, throw_range_error, throw_type_error - #797
Merged
Merged
Conversation
…row_type_error` Signed-off-by: Gae24 <96017547+Gae24@users.noreply.github.com>
TimvdLippe
approved these changes
Aug 18, 2026
moamenhesham0
pushed a commit
to moamenhesham0/servo
that referenced
this pull request
Aug 19, 2026
…r` (servo#47340) By switching to `throw_type_error_safe`, the unsafe blocks that wrapped dictionary types creation are no longer required. For the handful of cases where a callback is part of a dictionary, the unsafe blocks are now narrowed to the single function. Companion PR of servo/mozjs#797 Testing: It compiles --------- Signed-off-by: Gae24 <96017547+Gae24@users.noreply.github.com>
RichardTjokroutomo
pushed a commit
to RichardTjokroutomo/servo
that referenced
this pull request
Oct 6, 2026
…r` (servo#47340) By switching to `throw_type_error_safe`, the unsafe blocks that wrapped dictionary types creation are no longer required. For the handful of cases where a callback is part of a dictionary, the unsafe blocks are now narrowed to the single function. Companion PR of servo/mozjs#797 Testing: It compiles --------- Signed-off-by: Gae24 <96017547+Gae24@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testing: It compiles
Servo PR: servo/servo#47340