Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply @/theoparis' fixes for arm simd #575

Merged
merged 2 commits into from
Mar 21, 2025
Merged

Apply @/theoparis' fixes for arm simd #575

merged 2 commits into from
Mar 21, 2025

Conversation

itsjunetime
Copy link
Contributor

This fixes #571 by applying the changes found in https://github.com/theoparis/pathfinder. I'm not certain why @theoparis did not upstream these themself, but I would like this fix upstreamed, so I'm filing this.

I haven't tested this with versions of nightly before the rust commit that broke this code, so it might break those, but I expect there are more people are using the most recent version of nightly than people using versions that still work with pathfinder_simd.

@theoparis
Copy link

theoparis commented Feb 13, 2025

I didn't upstream this because I didn't realize these changes would work on stable rust with repr_simd feature-gated - I thought it required nightly rust. Thanks for creating this PR.

@itsjunetime
Copy link
Contributor Author

It does require nightly, but it seems that pathfinder has their own pf_rustc_nightly cfg to enable compilation that is conditional upon running it under nightly. I didn't realize that at first either, it took me a second of poking to see.

@strottos
Copy link

Hit this on my error on my ARM based Windows laptop from a different crate and this fix fixes things for me. Would approve of this being merged (or an indication of what needs to be done to be satisfied that this can be merged perhaps?).

@jdm jdm added this pull request to the merge queue Mar 21, 2025
Merged via the queue into servo:main with commit 8ccf6f7 Mar 21, 2025
2 checks passed
@ahcm
Copy link

ahcm commented Mar 24, 2025

As this breaks plotters via the font-kit dependancy, a release would be very welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compile error on nightly: invalid monomorphization, simd_shuffle index must be a SIMD vector
5 participants