Regenerate bindings #203
Merged
Regenerate bindings #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waywardmonkeys
force-pushed
the
regenerate-bindings
branch
from
8a6dbea
to
295e9a4
Compare
This fixes a bunch of warnings that happen when compiling tests as the old version of bindgen was generating worse code.
waywardmonkeys
force-pushed
the
regenerate-bindings
branch
from
295e9a4
to
2452c4f
Compare
|
So what's the deal with the documentation comments that were removed? Is the rust documentation still in place? |
waywardmonkeys
force-pushed
the
regenerate-bindings
branch
from
2452c4f
to
79f208a
Compare
|
I have added them back ... but they generate a lot of warnings as they are for the C API and aren't formatted nicely (or all that readably) here. |
mrobinson
approved these changes
Aug 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is essentially no functional change, but will make future diffs easier to verify (and fixes a bunch of warnings).