-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move freetype binding to separate module. #221
Move freetype binding to separate module. #221
Conversation
51bf369
to
c5689d5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks fine to me and I like the cleanup. The only issue here is that the new file is missing a license header. I understand that there are many files missing headers, but that's another issue we will need to fix. :)
Can I just add them all at once in something separate? |
I think adding the license header now and cleaning up the rest of the files later makes more sense. It's not great to have code without a proper license checked in. |
Give me the text you want, and I'll add it. None of the files in the |
(That's why I don't want to do it here: It is likely to be bikeshedded and no files in this crate have one.) |
The header refers to both licenses. I assume that MIT is included here because that is what HarfBuzz uses, but the rust code itself is specifically licensed under Apache as well. |
This makes it more like the others, and will keep it cleaner when we go and bind the other functions in this module. A license header is also added to match what is being added to the rest of the files in another PR / commit.
c5689d5
to
e20fbf1
Compare
Okay, added here, and the rest of the files and such updated in #225. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This makes it more like the others, and will keep it cleaner when we go and bind the other functions in this module.