ci: Build shared linux against system lib. #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stops building harfbuzz separately and tries just using the system install to make sure that works. This means that we build against an older version depending on what's available on Ubuntu (since our macOS build uses homebrew which tends to be fairly current). Currently, that's version 2.7.4, the same as we're currently building and packaging. Going forward, as we update what's in use here, that should help us make sure that we're working with older versions that can be found in the field, but we'll have to take care to feature-gate newer APIs.
mrobinson
approved these changes
Aug 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This stops building harfbuzz separately and tries just using the system install to make sure that works.
This means that we build against an older version depending on what's available on Ubuntu (since our macOS build uses homebrew which tends to be fairly current).
Currently, that's version 2.7.4, the same as we're currently building and packaging. Going forward, as we update what's in use here, that should help us make sure that we're working with older versions that can be found in the field, but we'll have to take care to feature-gate newer APIs.