Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Add windows-ci-shared that uses vcpkg. #229

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

waywardmonkeys
Copy link
Collaborator

This uses vcpkg to install a copy of Harfbuzz rather than using the bundled feature.

@waywardmonkeys waywardmonkeys marked this pull request as draft August 24, 2023 01:40
@mrobinson
Copy link
Member

It seems quite likely that you will need to use the vcpkg crate to set up the build in build.rs the same way that the harfbuzz-bindings crate does.

@waywardmonkeys
Copy link
Collaborator Author

Yes ... but then when digging into that, I found a whole bunch of other things that are wrong.

For this one, for example, the vcpkg package doesn't specifically enable directwrite on Windows, but we assume that it is available on Windows.

I've got some local branches where I start messing with default features, but I'm not excited about any of the approaches to changing it yet.

@waywardmonkeys
Copy link
Collaborator Author

Got a fix landed in vcpkg to allow not building with free type. Will add a direct write feature soon.

This uses `vcpkg` to install a copy of Harfbuzz rather than using
the `bundled` feature.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants