-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
script: Fix fetch-later length and quota computation #41665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
script: Fix fetch-later length and quota computation #41665
Conversation
|
🔨 Triggering try run (#20696064807) for Linux (WPT) |
|
🤖 Opened new upstream WPT pull request (web-platform-tests/wpt#56978) with upstreamable changes. |
|
Spec PR: whatwg/fetch#1902 |
ffb47df to
b75637e
Compare
|
📝 Transplanted new upstreamable changes to existing upstream WPT pull request (web-platform-tests/wpt#56978). |
|
Test results for linux-wpt from try job (#20696064807): Flaky unexpected result (39)
Stable unexpected results that are known to be intermittent (25)
Stable unexpected results (2)
|
|
|
|
Filed whatwg/fetch#1903. |
The specification isn't complete here and thus we were missing WPT coverage. Spec will be updated. Also, we are correctly throwing the QuotaExceededError with relevant information, while Chrome sets both fields to `null`. Therefore, the test now allows for both (since providing relevant information is good for the developer and recommended in the spec [1]). [1]: https://webidl.spec.whatwg.org/#ref-for-quotaexceedederror%E2%91%A2 Signed-off-by: Tim van der Lippe <[email protected]>
b75637e to
1a83ce2
Compare
|
📝 Transplanted new upstreamable changes to existing upstream WPT pull request (web-platform-tests/wpt#56978). |
The specification isn't complete here and thus we
were missing WPT coverage. Spec will be updated.
Also, we are correctly throwing the QuotaExceededError with relevant information, while Chrome sets both
fields to
null. Therefore, the test now allows for both (since providing relevant information is good for the developer and recommended in the spec 1).