-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare for v0.2.0
release
#151
Conversation
2342450
to
d5216b7
Compare
c41f34f
to
f698b43
Compare
I have updated this PR to also bump |
@mrobinson I've invited to all of the I've also updated the PR description with my understanding of the "order of operations" required for release. |
089031e
to
a788c9c
Compare
Signed-off-by: Nico Burns <nico@nicoburns.com>
This is my preference too, so no complaints from me! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the only thing missing here is using the upgraded version of cssparser
?
That already landed in #155 |
@mrobinson Ok, PR is merged! I believe it should now just be a case of running |
Prepare Stylo for a
v0.2.0
release. Closes #95.Dependencies
Before merging this and releasing we should:
This PR builds on:
Notes
I have gone for a simple versioning scheme where all
stylo*
crates have the same version. This means we don't have to worry about breaking vs. non-breaking changes for subcrates. And it makes it simple for consumers of Stylo to work out which version of the subcrates they ought to be depending on.selectors
andservo_arc
are still separately versioned.I propose that we (permanently) keep the following diff downstream:
version = "x.y.z"
line inCargo.toml
stylo
's dependency onstylo_traits
, but NOTstylo
's dependency oncssparser
).This will allow us to avoid triggering Gecko's/Mozilla's auditing process every time we bump a version number. And we need to maintain some level of diff of for
Cargo.toml
files anyway.Release Process
cssparser
v0.35 (Bump version to v0.35.0 rust-cssparser#404)cssparser
v0.35 (Upgrade to cssparser 0.35 #155):to_shmem_derive
andservo_arc
). A release order which should work is:cssparser
bump)(Servo will also need to be updated to
cssparser
v0.35, but that doesn't block this PR or Stylo release)