Mark tests as requiring Internet #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sethmlarson
previously approved these changes
Oct 18, 2023
|
@stefanor Could you run |
So that we can self-contained tests, when offline. The use-case here is packaging truststore in Debian. We like to run tests during our package builds, where possible. These build environments don't permit Internet access. We do have CI test environments that can access the Internet, but those happen after build. We'd run the full test suite there (inclnuding mkcert, which messes with the system certificate store). I see that the vast majority of the tests require Internet access, so I understand if you're not interested in this patch, because you aren't expecting much low-level test coverage.
No problem. You're a new (vendored) dependency of pip. So I want to have truststore packaged in the archive. |
sethmlarson
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So that we can self-contained tests, when offline.
The use-case here is packaging truststore in Debian. We like to run tests during our package builds, where possible. These build environments don't permit Internet access.
We do have CI test environments that can access the Internet, but those happen after build. We'd run the full test suite there (inclnuding mkcert, which messes with the system certificate store).
I see that the vast majority of the tests require Internet access, so I understand if you're not interested in this patch, because you aren't expecting much low-level test coverage.