-
Notifications
You must be signed in to change notification settings - Fork 2
chore(deps): update dependency glob to v13 #1443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
📦 Packages
|
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
| "console-table-printer": "^2", | ||
| "deepmerge-ts": "^7", | ||
| "environment": "^1", | ||
| "find-up": "^8.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: glob v13 fails to match paths on Windows due to path.join() generating backslashes, breaking monorepo package detection.
Severity: HIGH | Confidence: High
🔍 Detailed Analysis
On Windows, path.join() generates backslashes in paths passed to glob. With glob v13.0.0, backslashes are treated as escape characters instead of path separators. This causes the glob pattern join(monoRepoRoot, workspace, "package.json") in sdk/utils/src/filesystem/mono-repo.ts to fail matching any files. Consequently, allPaths becomes an empty array, leading to incorrect monorepo package detection and silent functional failure on Windows systems.
💡 Suggested Fix
Convert backslashes to forward slashes using .replace(/\\/g, '/') before passing paths to glob, or use the windowsPathsNoEscape: true option for glob on Windows.
🤖 Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: sdk/utils/package.json#L75
Potential issue: On Windows, `path.join()` generates backslashes in paths passed to
`glob`. With `glob` v13.0.0, backslashes are treated as escape characters instead of
path separators. This causes the glob pattern `join(monoRepoRoot, workspace,
"package.json")` in `sdk/utils/src/filesystem/mono-repo.ts` to fail matching any files.
Consequently, `allPaths` becomes an empty array, leading to incorrect monorepo package
detection and silent functional failure on Windows systems.
Did we get this right? 👍 / 👎 to inform future reviews.
Reference_id: 2826639
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No issues found across 2 files
This PR contains the following updates:
12.0.0->13.0.0Release Notes
isaacs/node-glob (glob)
v13.0.0Compare Source
Configuration
📅 Schedule: Branch creation - At 12:00 AM through 04:59 AM and 10:00 PM through 11:59 PM, Monday through Friday ( * 0-4,22-23 * * 1-5 ), Only on Sunday and Saturday ( * * * * 0,6 ) (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.