Skip to content
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
50 commits
Select commit Hold shift + click to select a range
f1b1f01
2주차 layout 과제
Huniiiiiii Sep 25, 2024
75ae0dd
2주차 recipe 과제
Huniiiiiii Sep 25, 2024
095b9ab
2week layout correction
Huniiiiiii Oct 30, 2024
271e132
Media_query
Huniiiiiii Oct 30, 2024
970596b
[fix] 평점 위치 수정 및 css, html코드 분리
Huniiiiiii Oct 30, 2024
99d9af7
[feat] layout page 미디어쿼리 적용
Huniiiiiii Oct 30, 2024
3d78639
[fix] 2주차 recipe파일 마진, 패딩 수정
Huniiiiiii Oct 30, 2024
dffe17d
[fix] media query02 css파일 추가
Huniiiiiii Nov 5, 2024
d2829c1
[fix]css글자체 추가
Huniiiiiii Nov 5, 2024
32e591b
[fix] 마진 줄이고 글자체 전부 적용(칼로리 제외 수정완)
Huniiiiiii Nov 5, 2024
8e2e6f9
[fix] nurtrition position
Huniiiiiii Nov 5, 2024
ebf4cb4
[fix] color, size
Huniiiiiii Nov 5, 2024
08ff921
[feat] todo_app main frame
Huniiiiiii Nov 8, 2024
65122f2
[fix] css 마진 수정 및 전체적인 디자인 완성
Huniiiiiii Nov 8, 2024
516ca75
[fix] 배경 이미지 넣고 hover시 바뀌는거 바꿈
Huniiiiiii Nov 9, 2024
921f35c
[fix] checkbox, fontweight
Huniiiiiii Nov 9, 2024
028a074
text add
Huniiiiiii Nov 9, 2024
e21f876
[fix] 배경에 보라색 화면으로 수정함 드디어~~!!
Huniiiiiii Nov 10, 2024
e2a8492
[fix] todo 이름 스타일 수정
Huniiiiiii Nov 10, 2024
981707a
[fix] todo style ㄹㅇ finish
Huniiiiiii Nov 10, 2024
6a3464b
[feat] drag and drop 기능 추가
Huniiiiiii Nov 10, 2024
3f80f77
add reacthookstudy
Huniiiiiii Nov 13, 2024
0a5095a
test
Huniiiiiii Nov 13, 2024
ba0c5f8
Merge branch 'Sehun' of https://github.com/seulnan/HTML-to-React into…
Huniiiiiii Nov 13, 2024
2113775
Del
Huniiiiiii Nov 13, 2024
45d4349
reacthook commit
Huniiiiiii Nov 13, 2024
71abf7b
Merge https://github.com/seulnan/HTML-to-React into Sehun
Huniiiiiii Nov 16, 2024
75d2be8
'test'
Huniiiiiii Nov 16, 2024
dd9333c
reacthookstudy_code
Huniiiiiii Nov 16, 2024
2b1effe
test
Huniiiiiii Nov 20, 2024
01965ba
test
Huniiiiiii Nov 20, 2024
9d39e01
"test"
Huniiiiiii Nov 20, 2024
fe96078
test
Huniiiiiii Nov 20, 2024
26bc6dd
[feat]tic-tac-toe main function make
Huniiiiiii Nov 20, 2024
0e955a1
[fix]MainMenuDesign수정
Huniiiiiii Nov 20, 2024
cbcd199
[fix]Menu style fix
Huniiiiiii Nov 20, 2024
a2c5e31
[fix]game화면 style수정
Huniiiiiii Nov 21, 2024
f462e48
[fix]점수출력오류수정
Huniiiiiii Nov 21, 2024
1a73d5a
[fix]game 화면 style
Huniiiiiii Nov 21, 2024
e8bf520
[fix]쓰레기 코드 삭제
Huniiiiiii Nov 21, 2024
1e0c23f
[fix]turn style, modal style, button style
Huniiiiiii Nov 22, 2024
96abcbb
[fix]Setting toggle button style
Huniiiiiii Nov 22, 2024
d030193
[fix]tie일때 modal문제수정
Huniiiiiii Nov 23, 2024
678306a
[fix] restart modal버튼 hover수정 및 비겻을때 모달 뜨게 하기 수정
Huniiiiiii Dec 18, 2024
9a33b68
[fix]modal글수정, 승리시 색추가 제공된 이미지의 한계로 최대한 해둠
Huniiiiiii Dec 20, 2024
7d8f99a
[fix] 이상한 오류 존재함 해결한듯
Huniiiiiii Dec 31, 2024
274b551
[fix] 어떤 오류인지 모르겟음 일단 해결
Huniiiiiii Dec 31, 2024
006f173
???
Huniiiiiii Dec 31, 2024
3f79d94
Merge branch 'Sehun' of https://github.com/seulnan/HTML-to-React into…
Huniiiiiii Dec 31, 2024
f7d702a
제발...
Huniiiiiii Dec 31, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 12 additions & 9 deletions recipe/recipe.css
Original file line number Diff line number Diff line change
Expand Up @@ -149,27 +149,27 @@ hr{

.nutrition-label {
flex: 1 0 0;
color: var(--color-brown-800, #854632);
color: var(--color-stone-600, #5F564D);
font-family: 'Outfit';
font-size: var(--font-size-desktop-text-preset-4, 16px);
font-style: normal;
font-weight: 700;
font-weight: 400;
line-height: 150%;
display: flex;
flex-direction: column;
align-items: flex-start;
gap: 12px;
align-self: stretch;
}

.nutrition-value {
flex: 1 0 0;
color: var(--color-stone-600, #5F564D);
color: var(--color-brown-800, #854632);
font-family: 'Outfit';
font-size: var(--font-size-desktop-text-preset-4, 16px);
font-style: normal;
font-weight: 400;
font-weight: 700;
line-height: 150%;
display: flex;
flex-direction: column;
align-items: flex-start;
gap: 12px;
align-self: stretch;
}

.iin_title1{
Expand All @@ -181,3 +181,6 @@ hr{
font-weight: 700;
}

.text_color_instruction{
color: var(--color-stone-600, #5F564D);
}
28 changes: 14 additions & 14 deletions recipe/recipe.html
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

피드백 남기겠습니다.
인상깊은 것

  1. 태그 이름을 다르게 해서 알아보기 쉬웠다
  2. 클래스 작명법이 탁월한 것 같아요

고칠것

  1. review 이미지 크기가 다름 - css 수정
  2. 박스 크기가 가로 세로로 너무 김 - width height 데브모드 보고 정확히 지정 가능
  3. 이후 박스 왼쪽 마진을 좀 줘서 텍스트와 맞춰야 할 것 같음
  4. body를 감싸는 container를 따로 만들었는데 굳이? 싶음 바로 body에 크기 및 여타 css 적용해도 될 듯
  5. background 적용 안됨 - absolute 쓰면 편함
  6. 미디어쿼리 상태에서 제목, 부제, 박스 안 텍스트, 박스크기, body 사이즈 기타등등 에 스타일이 적용 안됨 - 적용만 하면 배열은 알맞아서 피그마 모양대로 바뀔듯

Original file line number Diff line number Diff line change
Expand Up @@ -22,21 +22,21 @@
<svg xmlns="http://www.w3.org/2000/svg" width="4" height="4" viewBox="0 0 4 4" fill="none">
<circle cx="2" cy="2" r="2" fill="#7A284E"/>
</svg>
<span><b>Total:</b> Approximately 10 minutes</span>
<span class = "text_color_instruction"><b>Total:</b> Approximately 10 minutes</span>
</p>

<p class="frame265">
<svg xmlns="http://www.w3.org/2000/svg" width="4" height="4" viewBox="0 0 4 4" fill="none">
<circle cx="2" cy="2" r="2" fill="#7A284E"/>
</svg>
<span><b>Preparation:</b> 5 minutes</span>
<span class = "text_color_instruction"><b>Preparation:</b> 5 minutes</span>
</p>

<p class="frame265">
<svg xmlns="http://www.w3.org/2000/svg" width="4" height="4" viewBox="0 0 4 4" fill="none">
<circle cx="2" cy="2" r="2" fill="#7A284E"/>
</svg>
<span><b>Cooking:</b> 5 minutes</span>
<span class = "text_color_instruction"><b>Cooking:</b> 5 minutes</span>
</p>
</div>

Expand All @@ -46,56 +46,56 @@
<svg xmlns="http://www.w3.org/2000/svg" width="4" height="4" viewBox="0 0 4 4" fill="none">
<circle cx="2" cy="2" r="2" fill="#7A284E"/>
</svg>
<span>2-3 large eggs</span>
<span class = "text_color_instruction">2-3 large eggs</span>
</p>

<p class="frame265">
<svg xmlns="http://www.w3.org/2000/svg" width="4" height="4" viewBox="0 0 4 4" fill="none">
<circle cx="2" cy="2" r="2" fill="#7A284E"/>
</svg>
<span>Salt, to taste</span>
<span class = "text_color_instruction">Salt, to taste</span>
</p>

<p class="frame265">
<svg xmlns="http://www.w3.org/2000/svg" width="4" height="4" viewBox="0 0 4 4" fill="none">
<circle cx="2" cy="2" r="2" fill="#7A284E"/>
</svg>
<span>Pepper, to taste</span>
<span class = "text_color_instruction">Pepper, to taste</span>
</p>

<p class="frame265">
<svg xmlns="http://www.w3.org/2000/svg" width="4" height="4" viewBox="0 0 4 4" fill="none">
<circle cx="2" cy="2" r="2" fill="#7A284E"/>
</svg>
<span>1 tablespoon of butter or oil</span>
<span class = "text_color_instruction">1 tablespoon of butter or oil</span>
</p>

<p class="frame265">
<svg xmlns="http://www.w3.org/2000/svg" width="4" height="4" viewBox="0 0 4 4" fill="none">
<circle cx="2" cy="2" r="2" fill="#7A284E"/>
</svg>
<span>Optional fillings: cheese, diced vegetables, cooked meats, herbs</span>
<span class = "text_color_instruction">Optional fillings: cheese, diced vegetables, cooked meats, herbs</span>
</p>
</div>

<div class="instructions">
<p class="iin_title">Instructions</p>
<p class="frame266">
<span class = "iin_title1">1.</span><span><b>Beat the eggs:</b> In a bowl, beat the eggs with a pinch of salt and pepper until they are well mixed. You can add a tablespoon of water or milk for a fluffier texture.</span>
<span class = "iin_title1">1.</span><span class = "text_color_instruction"><b>Beat the eggs:</b> In a bowl, beat the eggs with a pinch of salt and pepper until they are well mixed. You can add a tablespoon of water or milk for a fluffier texture.</span>
</p>
<p class="frame266">
<span class = "iin_title1">2.</span><span><b>Heat the pan:</b> Place a non-stick frying pan over medium heat and add butter or oil.</span>
<span class = "iin_title1">2.</span><span class = "text_color_instruction"><b>Heat the pan:</b> Place a non-stick frying pan over medium heat and add butter or oil.</span>
<p class="frame266">
<span class = "iin_title1">3.</span><span><b>Cook the omelette:</b> Once the butter is melted and bubbling, pour in the eggs. Tilt the pan to ensure the eggs evenly coat the surface.</span>
<span class = "iin_title1">3.</span><span class = "text_color_instruction"><b>Cook the omelette:</b> Once the butter is melted and bubbling, pour in the eggs. Tilt the pan to ensure the eggs evenly coat the surface.</span>
</p>
<p class="frame266">
<span class = "iin_title1">4.</span><span><b>Add fillings (optional):</b> When the eggs begin to set at the edges but are still slightly runny in the middle, sprinkle your chosen fillings over one half of the omelette.</span>
<span class = "iin_title1">4.</span><span class = "text_color_instruction"><b>Add fillings (optional):</b> When the eggs begin to set at the edges but are still slightly runny in the middle, sprinkle your chosen fillings over one half of the omelette.</span>
</p>
<p class="frame266">
<span class = "iin_title1">5.</span><span><b>Fold and serve:</b> As the omelette continues to cook, carefully lift one edge and fold it over the fillings. Let it cook for another minute, then slide it onto a plate.</span>
<span class = "iin_title1">5.</span><span class = "text_color_instruction"><b>Fold and serve:</b> As the omelette continues to cook, carefully lift one edge and fold it over the fillings. Let it cook for another minute, then slide it onto a plate.</span>
</p>
<p class="frame266">
<span class = "iin_title1">6.</span><span><b>Enjoy:</b> Serve hot, with additional salt and pepper if needed.</span>
<span class = "iin_title1">6.</span><span class = "text_color_instruction"><b>Enjoy:</b> Serve hot, with additional salt and pepper if needed.</span>
</p>
</div>
<hr/>
Expand Down