Skip to content

Conversation

kalloc
Copy link
Contributor

@kalloc kalloc commented May 19, 2025

The workflow includes the following jobs:

  1. fmt: Checks code formatting using cargo fmt --check.
  2. clippy: Runs clippy on the codebase to catch potential issues.
  3. cargo_sort: Utilizes cargo-sort to ensure Cargo.toml files are sorted correctly.
  4. machete: Checks for unused Cargo dependencies using cargo-machete.

Additionally, a new file named .pre-commit.sh is added with a script to install necessary tools and run code quality checks before committing changes. The script also offers to set itself as the git pre-commit hook for convenience.

p.s.: I skipped decoders in typos due to various errors from the original IDLs

--

From Deluge with love!

Copy link
Collaborator

@sonicfromnewyoke sonicfromnewyoke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks amazing, would you mind adding small description in the root README.md on how to install git hooks based on the git documentation ?

@kalloc
Copy link
Contributor Author

kalloc commented May 19, 2025

Can I add problem fixes to this PR ? @sonicfromnewyoke

@kalloc
Copy link
Contributor Author

kalloc commented May 19, 2025

I just updated readme @sonicfromnewyoke

@kalloc
Copy link
Contributor Author

kalloc commented May 19, 2025

@sonicfromnewyoke I'd like to fix current issues, can I add a commit to this PR?

@sonicfromnewyoke
Copy link
Collaborator

@sonicfromnewyoke I'd like to fix current issues, can I add a commit to this PR?

sure, you're welcome ☺️

@kalloc
Copy link
Contributor Author

kalloc commented May 19, 2025

@sonicfromnewyoke there you go, my suggestion is to squash and merge

@sonicfromnewyoke sonicfromnewyoke merged commit 2218f8c into sevenlabs-hq:main May 20, 2025
5 checks passed
@sonicfromnewyoke
Copy link
Collaborator

@sonicfromnewyoke there you go, my suggestion is to squash and merge

sorry for the delay in review 😔

everything is cool, and i'd even say: "this is a move which turns pet-projects into the professional software"

many thanks, one more time for that huge leap in the software development quality of the Carbon, you are awesome 🤩

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants