-
Notifications
You must be signed in to change notification settings - Fork 137
feat: add linting and .pre-commit hook #306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks amazing, would you mind adding small description in the root README.md
on how to install git hooks
based on the git documentation ?
Can I add problem fixes to this PR ? @sonicfromnewyoke |
I just updated readme @sonicfromnewyoke |
@sonicfromnewyoke I'd like to fix current issues, can I add a commit to this PR? |
sure, you're welcome |
@sonicfromnewyoke there you go, my suggestion is to squash and merge |
sorry for the delay in review 😔 everything is cool, and i'd even say: "this is a move which turns pet-projects into the professional software" many thanks, one more time for that huge leap in the software development quality of the Carbon, you are awesome 🤩 |
The workflow includes the following jobs:
fmt
: Checks code formatting usingcargo fmt --check
.clippy
: Runs clippy on the codebase to catch potential issues.cargo_sort
: Utilizescargo-sort
to ensureCargo.toml
files are sorted correctly.machete
: Checks for unused Cargo dependencies usingcargo-machete
.Additionally, a new file named
.pre-commit.sh
is added with a script to install necessary tools and run code quality checks before committing changes. The script also offers to set itself as the git pre-commit hook for convenience.p.s.: I skipped decoders in typos due to various errors from the original IDLs
--
From Deluge with love!