Skip to content

fixed raw html displaying on forms #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tscurrie wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fixed raw html displaying on forms #39

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,7 @@ group :development, :test do
end

group :development do
gem 'meta_request'

@nathanallen nathanallen Feb 5, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you add this gem?

# Access an IRB console on exception pages or by using <%= console %> in views
gem 'web-console', '~> 2.0'

Expand Down
4 changes: 2 additions & 2 deletions app/views/devise/sessions/new.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,11 @@
<%= form_for(resource, as: resource_name, url: session_path(resource_name)) do |f| %>
<fieldset>
<div class="form-group">
<%= f.text_field :login, class: 'form-control', placeholder: t('.login'), autofocus: true %>
<%= f.text_field :login, class: 'form-control', placeholder: 'Login', autofocus: true %>

@nathanallen nathanallen Feb 5, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will not merge.

This app needs to work for non-english speakers.

</div>

<div class="form-group">
<%= f.password_field :password, class: 'form-control', placeholder: t('.password'), autocomplete: 'off' %>
<%= f.password_field :password, class: 'form-control', placeholder: 'Password', autocomplete: 'off' %>
</div>

<div class="checkbox">
Expand Down