Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add note to README about assigning labels for new issues #409

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nickvisut
Copy link
Contributor

Addresses #368

Copy link
Contributor

@mrabbitt mrabbitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me, though perhaps it could use some more explanation regarding feature requests (see my other comment).

Also, will these instructions need to be updated again if we introduce issue templates which automatically add the labels (as per one of the line items in #368)?

This should probably be reviewed by someone else who's been around longer than me and is familiar with the way the team works.

@@ -7,6 +7,15 @@ Useful resources:
- [Notion wiki](https://www.notion.so/sfbrigade/Compass-source-of-truth-db118a6d51344dccadc49d1988662d66)
- [Slack channel](https://sfbrigade.slack.com/archives/C01R8E75N1K)

## Filing a new issue

If you run into an issue or would like to request a feature, please file an issue.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For an issue that requests a new feature, it may require both UX design work and engineering work. What label(s) are appropriate in that situation?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it sounds like we may no longer need these labels. if so, we could get rid of them and the prefixes (at least moving forward)

@tam-janice, given the new board structure, will we no longer have separate eng and dev tickets? asking b/c traditionally the tickets were either prefixed with [ENG] or [UX] (or alternatively assigned similar labels).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we could also repurpose the labels for "engineering"-only (tech stuff, chores) and "UX"-only tickets (design that isn't meant to be handed off to dev), which would distinguish them from a story/task that goes through the whole lifecycle.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's what I'm thinking:

  • We remove the prefixes [eng] and [UX]
  • We will keep the column 'in design'
  • If something needs design, it'll jsut be assigned to me and I'll take care of it
  • there will never be a ticket that reqires both UX and eng. If it's an eng ticket design should already be done

Does this work?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants