Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SATELLITE LINKS] PR 1: CSV Parsing module in utils #555

Merged
merged 7 commits into from
Jul 1, 2024

Conversation

pfittipaldi
Copy link
Collaborator

@pfittipaldi pfittipaldi commented Jun 7, 2024

This PR adds a small CSV parsing module, that will be useful for the free space channels.


This change is Reviewable

Copy link
Contributor

@zigen zigen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @pfittipaldi)


spdlog line 1 at r1 (raw file):

Subproject commit ac55e60488032b9acde8940a5de099541c4515da

why did you update this? what's this commit?


quisp/utils/CSVParser.h line 17 at r1 (raw file):

using std::string;

class CSVParser {

I think this is not a general CSV file Parser. so you should choose specific name like FreeSpaceChannelConfigParser

Copy link
Contributor

@zigen zigen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @pfittipaldi)

Copy link
Contributor

@zigen zigen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @pfittipaldi)

@zigen
Copy link
Contributor

zigen commented Jun 28, 2024

@pfittipaldi it's ready to merge. you can mark as "ready for review" and then merge it.

@pfittipaldi pfittipaldi marked this pull request as ready for review July 1, 2024 15:03
@pfittipaldi pfittipaldi merged commit a29f779 into master Jul 1, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants