Changing hi-hat pedal behavior #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updating the maps that put the instruments together. This is the main part of the change.
Pasted the wrong file in the previous commits for these two... now should be actually the default.
Supposed to be the defaults here... not the pedal alt, which I had in the main folder as I was testing it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An update which does a few things:
Adds CC4 range as defined variables for the closed hi-hat, so it can now be on the same key as half-open, 3/4 and open.
Adds a third variant of the GUI, so the hi-hat CC4 control is a fader, not a drop-down menu.
Adds hi-hat pedal offset as two defined variables (one for regular mic positions, another for epic) to control the pedal preroll, which is currently about 2500 samples.
This is based on a request from an e-kit user who needs everything from open to closed on one note, and also wants the pedal sound to respond faster.