Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add /lib64 reference again and tell abuild to allow it #180

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pablosole
Copy link

Re-enable /lib64 linking and add an option on APKBUILD to allow it. This should resolve issues #175 and #176.

@thotypous
Copy link

Solves #181

@danisevas
Copy link

@sgerrand Hey, sorry to bother you again today.
Can you please accept/reject this pr? it solves some (duplicates) issues and is a different (and simpler) solution to #179

APKBUILD Show resolved Hide resolved
Copy link
Owner

@sgerrand sgerrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for the incredibly delayed review.

APKBUILD Show resolved Hide resolved
@@ -13,9 +13,10 @@ nsswitch.conf
ld.so.conf"
subpackages="$pkgname-bin $pkgname-dev $pkgname-i18n"
triggers="$pkgname-bin.trigger=/lib:/usr/lib:/usr/glibc-compat/lib"
options="lib64"

package() {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest adding this line to prevent issues for users of libc6-compat.

Suggested change
package() {
package() {
conflicts="libc6-compat"

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To illustrate this problem in action:

fetch https://dl-cdn.alpinelinux.org/alpine/v3.15/main/x86_64/APKINDEX.tar.gz
fetch https://dl-cdn.alpinelinux.org/alpine/v3.15/community/x86_64/APKINDEX.tar.gz
(1/10) Installing glibc (2.35-r0)
(2/10) Installing ncurses-terminfo-base (6.3_p20211120-r1)
(3/10) Installing ncurses-libs (6.3_p20211120-r1)
(4/10) Installing readline (8.1.1-r0)
(5/10) Installing bash (5.1.16-r0)
Executing bash-5.1.16-r0.post-install
(6/10) Installing libc6-compat (1.2.2-r7)
ERROR: libc6-compat-1.2.2-r7: trying to overwrite lib64/ld-linux-x86-64.so.2 owned by glibc-2.35-r0.
(7/10) Installing libgcc (10.3.1_git20211027-r0)
(8/10) Installing glibc-bin (2.35-r0)
(9/10) Installing glibc-dev (2.35-r0)
(10/10) Installing glibc-i18n (2.35-r0)
Executing busybox-1.34.1-r7.trigger
Executing glibc-bin-2.35-r0.trigger
1 error; 109 MiB in 24 packages

Exited with code exit status 1

(source)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see why this change is probably needed, but doesn't this conflict with

bin() {
depends="$pkgname bash libc6-compat libgcc"
which actually installs libc6-compat as a dependency of glibc-bin?

Is it possible that dependency added in 3987862 be removed? It's a bit confusing as to why if we are installing glibc that we would want a dependency on a musl/glibc compatibility layer like libc6-compat as it does in the 2.35-r0/2.35-r1 glibc-bin packages and not so clear which user-reported issues were being addressed by that addition.

@pablosole
Copy link
Author

Sorry, I lost track of this. Added the conflicts suggestion, dropped the dependency on bin(), and increased the pkgrel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants