-
Notifications
You must be signed in to change notification settings - Fork 486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Debug studio #1831
Open
zolinthecow
wants to merge
31
commits into
sgl-project:main
Choose a base branch
from
zolinthecow:debug-studio
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Debug studio #1831
+589
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zolinthecow
requested review from
merrymercy,
Ying1123,
ByronHsu and
hnyls2002
as code owners
October 29, 2024 07:04
^ Couldn't reproduce CI error locally :( |
@zolinthecow Nice work! I will start to review this PR this weekend. Stay tuned! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When developing apps (especially more complex ones) with SGLang's frontend it's a bit hard to tell what is actually getting passed into the
generate/
endpoint. This PR introduces a "prompt debugging studio" that allows you to turn on a debug mode and will start intercepting generate requests and saving them to a debug server, where you can go to a web interface and view all the prompts and responses for SGL functions.For example, if you start the debug server:
It will start a debug server on
http://0.0.0.0:56765
Then, you can add a debug region to an sgl function:
The
s.begin_debug_region
will start debugging under the prompt name "TEXT_QA". You can then go tohttp://localhost:56765
(will have to ssh forward if you're developing on a remote server) and you should see prompts start appearingModifications
launch_debug_server
which under the hood relies onenochian-studio
(one of my packages) for the debug serverenochian-studio
can be found here, I can say it's up to date since I maintain it, along with EtchedChecklist