-
Notifications
You must be signed in to change notification settings - Fork 486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Instructions on Profiling SGLang Infer System with AMD GPUs #1929
base: main
Are you sure you want to change the base?
Conversation
@leishaoSC , LGTM and thanks! |
May we consider adding this document to https://github.com/sgl-project/sgl-project.github.io cc @zhaochenyang20 |
@leishaoSC Thanks for the contribution. Can you resolve the conflicts? |
@merrymercy I have resolved the conflicts just now. Thanks. |
@leishaoSC Can you fix the lint? |
Gemma2 reward model support (sgl-project#1954)
It still fails. Can you try https://github.com/sgl-project/sglang/blob/main/docs/references/contributor_guide.md#format-your-code? |
I have formatted my code. does it work now? Thanks |
@merrymercy , I found in "cat .github/pull_request_template.md" my last 3 lines are unchecked. Is this ignorable or not? In addition, could you please help to rerun lint check? Thanks. |
Hi @merrymercy , I have made server.sh, client.sh, loadTracer.sh executable before I add/commit/push. However, I still saw the error "check that scripts with shebangs are executable..........................Failed
|
You can delete the sglang/.pre-commit-config.yaml Line 20 in f9a377f
But you also failed multiple other tests such as |
@merrymercy , I have delete the |
Hi @merrymercy, I created a new PR #1966 from another feature branch. Hope it can work this time. Thanks. |
Motivation
Modifications
Checklist