Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instructions on Profiling SGLang Infer System with AMD GPUs #1929

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

leishaoSC
Copy link

@leishaoSC leishaoSC commented Nov 5, 2024

Motivation

Modifications

Checklist

  • Format your code according to the Contributor Guide.
  • Add unit tests as outlined in the Contributor Guide.
  • Update documentation as needed, including docstrings or example tutorials.

@HaiShaw
Copy link
Contributor

HaiShaw commented Nov 5, 2024

@leishaoSC , LGTM and thanks!

@zhyncs
Copy link
Member

zhyncs commented Nov 6, 2024

May we consider adding this document to https://github.com/sgl-project/sgl-project.github.io cc @zhaochenyang20

@merrymercy
Copy link
Contributor

@leishaoSC Thanks for the contribution. Can you resolve the conflicts?

@leishaoSC
Copy link
Author

@leishaoSC Thanks for the contribution. Can you resolve the conflicts?

@merrymercy I have resolved the conflicts just now. Thanks.

@merrymercy
Copy link
Contributor

@leishaoSC Can you fix the lint?

@merrymercy
Copy link
Contributor

@leishaoSC
Copy link
Author

It still fails. Can you try https://github.com/sgl-project/sglang/blob/main/docs/references/contributor_guide.md#format-your-code?

I have formatted my code. does it work now? Thanks

@leishaoSC
Copy link
Author

@merrymercy , I found in "cat .github/pull_request_template.md" my last 3 lines are unchecked. Is this ignorable or not? In addition, could you please help to rerun lint check? Thanks.

@leishaoSC
Copy link
Author

Hi @merrymercy , I have made server.sh, client.sh, loadTracer.sh executable before I add/commit/push. However, I still saw the error "check that scripts with shebangs are executable..........................Failed

  • hook id: check-shebang-scripts-are-executable
  • exit code: 1". Could you please suggest how to fix it? Thanks.

@merrymercy
Copy link
Contributor

merrymercy commented Nov 8, 2024

You can delete the check-shebang-scripts-are-executable check in

- id: check-executables-have-shebangs
. I think it is too restrict.

But you also failed multiple other tests such as trim trailing whitespace. Can you make sure they pass locally before pushing?

@leishaoSC
Copy link
Author

You can delete the check-shebang-scripts-are-executable check in

- id: check-executables-have-shebangs

. I think it is too restrict.
But you also failed multiple other tests such as trim trailing whitespace. Can you make sure they pass locally before pushing?

@merrymercy , I have delete the check-shebang-scripts-are-executable check in in my local .pre-commit-config.yaml. But when I ran "pre-commit run --all-files", I still saw one check failed, "don't commit to branch...................................................Failed

  • hook id: no-commit-to-branch
  • exit code: 1". In my local test, other checks all passed. Could you please suggest how I fix the "don't commit to branch" failed issue? In addition, what do you suggest I do to avoid the commit has more failed check on the Lint test? Thanks.
    image

@leishaoSC
Copy link
Author

Hi @merrymercy, I created a new PR #1966 from another feature branch. Hope it can work this time. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants