Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] Status-bar-hiding avoiding code doesn't work consistently #52

Open
benguild opened this issue May 31, 2018 · 1 comment
Open

[bug] Status-bar-hiding avoiding code doesn't work consistently #52

benguild opened this issue May 31, 2018 · 1 comment

Comments

@benguild
Copy link

benguild commented May 31, 2018

This doesn't always work:
https://github.com/sgr-ksmt/PullToDismiss/blob/master/Sources/PullToDismiss.swift#L173-L175

Example: if you drag a UINavigationController with a UIViewController that has a UIScrollView in it, upward (into negative space) before dragging it downward, it may skip over the detection range of 0 -> 0.5 that's prescribed here, and the status bar is hidden on that view.

Depending on what you're doing, this is an oversight.

@benguild
Copy link
Author

benguild commented Jun 1, 2018

Honestly, now that I've looked into a bit more about how this works, it really makes more sense to just use UIViewControllerAnimatedTransitioning instead, as it's very lightweight... and avoids this kind of status bar jumpiness.

I may share a Gist later on with a demo in Swift 4.1: https://gist.github.com/benguild

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant