Fixing issue with UIPageViewController outermost parent.
#49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that this works well with
UIPageViewController(embedded within an additional parent, for example) only if resolving the topmost parentUIViewController. I'm assuming that this is probably most ideal in all situations, but that the previous convenience of calling "dismiss" on the closestUIViewControlleralso worked in most instances.This fixes the issue that I ran into. — An alternative would be to have a
weakproperty that can be overridden to track whichUIViewControllerto actually dismiss in case it's a less typical choice, but I'm guessing that's unnecessary.