feat(blocks): make sidebar nav items without children render as SidebarMenuButton for sidebar-07 & sidebar-08#6107
Closed
blackstarxr253 wants to merge 4 commits intoshadcn-ui:mainfrom
blackstarxr253:improved-sidebar-nav
Closed
feat(blocks): make sidebar nav items without children render as SidebarMenuButton for sidebar-07 & sidebar-08#6107blackstarxr253 wants to merge 4 commits intoshadcn-ui:mainfrom blackstarxr253:improved-sidebar-nav
blackstarxr253 wants to merge 4 commits intoshadcn-ui:mainfrom
blackstarxr253:improved-sidebar-nav
Conversation
Contributor
|
@blackstarxr253 is attempting to deploy a commit to the shadcn-pro Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For nav elements that you don't want to render as a collapsible, I added a check that changes the render to a standard SidebarNavButton as long as the nav object has no children
Example
Nav entry with children
since it has children, it should display as a collapsible

Nav entry without children
since dashboard has no children, it should render as a button instead
