fix(button): add dark:hover styles to outline variant #9186
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix outline button hover in dark mode
The outline button variant defines a
dark:bg-*background but does not include a correspondingdark:hover:*style.Because
.dark .buttonhas higher specificity than.button:hover, the dark background overrides the hover background, making hover styles appear broken in dark mode while still working correctly in light mode.What this PR does
dark:hover:bg-*to the outline button variantReproduction
After this change, hover works consistently in both light and dark modes.
Fixes #9175