Support for Android O preview #1258

Mygod · 2017-05-18T07:21:32Z

DO NOT MERGE YET! This is a work in progress.

Note: Fixes for NDK compiling issues (and other related stuff) have already been merged to master branch.

TODO

Notification channel
NB: it's possible that NAT service notifications in lock screen are not hiding correctly, needs more tests
Overture crashing (looks like Android emulator bug)
Replace Typeface with native font support with support library (blocked by upstream: New font resources not recognized scala-android/sbt-android#306)
Port plugin platform to Android O
Use PreferenceDataStore to make SharedPreference process-safe (a historical problem)

Lower priorities:

Adaptive icon?

* Update support library to beta1; * Adapt to new foreground service policy; * Add a separate notification channel for NAT service; * Adapt to `findViewById` method signature changes. Possible issues: NAT notification will possibly not hide in lockscreen.

Mygod · 2017-05-18T07:23:42Z

@madeye Could you investigate why overture is crashing? It seems to crash when launched by Shadowsocks:

12067-12756/com.github.shadowsocks:bg D/GuardedProcess: start process: /data/app/com.github.shadowsocks-QkCmGBEGOrqtXp1bS-DAgQ==/lib/x86/liboverture.so -c overture-vpn.conf -V
12067-12756/com.github.shadowsocks:bg W/GuardedProcess: process exit too fast, stop guard: /data/app/com.github.shadowsocks-QkCmGBEGOrqtXp1bS-DAgQ==/lib/x86/liboverture.so -c overture-vpn.conf -V

However launching it from adb shell (with root/correct uid, and correct cwd) works fine:

12858-12858/? I/overture: level=info msg="If you need any help, please visit the project repository: https://github.com/shadowsocks/overture" 
12858-12862/? I/overture: level=info msg="Load IP network file successful" 
12858-12862/? I/overture: level=info msg="Load domain file successful" 
12858-12862/? I/overture: level=info msg="Minimum TTL is 3600" 
12858-12862/? I/overture: level=info msg="CacheSize is 4096" 
12858-12862/? I/overture: level=info msg="Load hosts file successful" 
12858-12862/? I/overture: level=info msg="Start overture on 127.0.0.1:1133"

madeye · 2017-05-18T07:26:10Z

I don't have any Android O device yet. Let me try it on emulator first.

It looks related to new private API protector or something similar.

Mygod · 2017-05-18T07:29:37Z

@madeye I'm just trying it on emulator as well.

Also I just noticed that there's a new option in VPN settings: "Block connections without VPN" for "Always-on VPN". This could be useful for users that are concerned about security.

madeye · 2017-05-18T10:34:50Z

I can reproduce this issue on the emulator now. The process of overture is killed at the very beginning. No related log or dmesg can be found.

madeye · 2017-05-18T11:57:15Z

I just tried 4.1.7. Everything works well on Android O (Pixel and Emulator)...

madeye · 2017-05-18T12:05:28Z

OK, It looks related to https://developer.android.com/preview/features/background.html

Mygod · 2017-05-18T12:09:22Z

@madeye But why does the C binaries work well?

madeye · 2017-05-18T12:10:46Z

I tried starting kcptun plugin with shadowsocks. In that case, ss-local is also killed...

madeye · 2017-05-18T12:40:58Z

Is it possible that the issue is caused by this d5dc3a8?

madeye · 2017-05-18T13:02:57Z

Interesting. It seems only the emulator is not working. The latest APK works well on Pixel with Android O.

Mygod · 2017-05-18T15:24:50Z

@madeye Haha what a mysterious bug.

IIRC old GCC binaries (compiled with old ndk) doesn't work either. So no.

You could do a single stepping with gdb. Could be a bug in qemu?

Mygod · 2017-05-18T15:31:00Z

*actually old GCC binaries exhibits more bug even when launched from adb shell (in preview 1). For example, failure to load any file other than overture-vpn.conf. (it gives open : file or directory not found)

Mygod · 2017-05-18T15:49:48Z

It might also relate to some changes in Android for NDK: https://android.googlesource.com/platform/bionic/+/master/android-changes-for-ndk-developers.md#Writable-and-Executable-Segments-Enforced-for-API-level-26

madeye · 2017-05-19T08:46:56Z

A new finding is it seems we cannot execute a armv7a binary from a arm64-v8a process on Android O. It caused the crash of kcptun plugin and has been fixed via shadowsocks/kcptun-android@90b2b38

Mygod · 2017-05-19T08:50:34Z

That doesn't seem to help.

madeye · 2017-05-19T08:56:47Z

Maybe it's just a bug of x86 emulator? According to my local test, shadowsocks (with kcptun and simple-obfs) works well on a Pixel (Android O).

Let's wait for the next release of Android O SDK and emulator. Hope it will fix our issue.

Mygod · 2017-05-19T09:05:50Z

Okay. Maybe we should file a bug report at Google issue tracker.

Mygod · 2017-05-22T03:51:40Z

@madeye Btw planning on migrating to Kotlin?

madeye · 2017-05-22T04:05:32Z

@Mygod Yes, I think we can schedule this.

madeye · 2017-05-22T04:12:05Z

BTW, is there any tool can easily convert Scala to Kotlin?

madeye · 2017-05-22T04:24:35Z

What about creating a new branch for Kotlin porting effort?

Mygod · 2017-05-22T08:22:19Z

Okay I'll look into this and create a branch for Kotlin based off o-preview branch.

Because our data store is process-safe, we can remove the `use` function entirely and move more components to :bg process.

madeye · 2017-07-15T23:14:50Z

No function regression is observed in the latest changes.

One weird thing is now we need to long press the number picker dialog to enter the number manually.

madeye · 2017-07-15T23:20:26Z

What about reverting number picker to number only edit text for port numbers? Actually, I never used the picker to change the port number...

madeye · 2017-07-15T23:55:25Z

A trade off is keeping the number picker for local port, but using edit text for remote port. It helps to avoid illegal local port numbers.

Mygod · 2017-07-16T02:34:18Z

ShadowsocksRunnerActivity is not tested. Everything else seems to work fine on Android 7.1.2, including number picker. I will go investigate number picker on Android 8.0 later.

Mygod · 2017-07-16T03:18:36Z

Keyboard is also popping up for me in Android 8.0 emulator.

Mygod · 2017-07-16T07:12:35Z

Adaptive icons are here. Design source.

From: Adaptive icon playground.

Mygod · 2017-07-16T07:24:01Z

This app is now Android 8.0 ready and this PR is ready to merge.

madeye · 2017-07-16T08:09:40Z

Fix a crash in ShadowsocksRunnerActivity that the activity exists too early when preparing VPN in background service.

madeye · 2017-07-16T08:13:10Z

The only one item left is the number picker for port number.

Soft keyboard shows up correctly.
However, the number picker is not focused by default.
By long pressing the picker, the user is able to input the number manually.

What I've tried:

requestFocus() at first, but it seems to not work.

madeye · 2017-07-16T08:25:08Z

Surprisingly, after enlarging the text size of number picker, I managed to focus number picker by clicking now...

IMO, It looks that if the number text is too small, the click action may be recognized as scrolling, which prevents focusing the text and enabling manual input.

madeye · 2017-07-19T01:00:47Z

A new crash is observed during auto start:

1757 07-19 08:52:48.596  5926  6596 E AndroidRuntime: java.lang.NullPointerException: Attempt to invoke virtual method 'void        java.util.concurrent.CountDownLatch.countDown()' on a null object reference
1758 07-19 08:52:48.596  5926  6596 E AndroidRuntime:    at com.evernote.android.job.JobRescheduleService.                          onHandleIntent(JobRescheduleService.java:104)
1759 07-19 08:52:48.596  5926  6596 E AndroidRuntime:    at android.app.IntentService$ServiceHandler.                               handleMessage(IntentService.java:68)
1760 07-19 08:52:48.596  5926  6596 E AndroidRuntime:    at android.os.Handler.dispatchMessage(Handler.java:105)
1761 07-19 08:52:48.596  5926  6596 E AndroidRuntime:    at android.os.Looper.loop(Looper.java:164)
1762 07-19 08:52:48.596  5926  6596 E AndroidRuntime:    at android.os.HandlerThread.run(HandlerThread.java:65)

Steps to reproduce this crash:

Set auto start enable.
Restart the phone.
Unlock the phone.
Wait until VPNService is started.
Open Shadowsocks' main activity.
Wait 30 seconds.

It looks an issue of evernote/android-job library.

madeye · 2017-07-19T01:18:06Z

Updating the library to 1.2.0-alpha3 fixed the issue via d8179b5.

Mygod · 2017-10-28T07:04:53Z

Update: It's not possible to dynamically update notification channel's importance in Oreo: (source)

The importance of an existing channel will only be changed if the new importance is lower than the current value and the user has not altered any settings on this channel. All other fields are ignored for channels that already exist.

Mygod · 2019-06-15T05:32:13Z

Updated design for Google Play new icon specification.

Support for Android O preview

Mygod added 4 commits May 18, 2017 14:35

Update target SDK to O preview

1ec8017

Use the new findViewById APIs

0acfaa1

Add support for notification channels for O preview

bbf52c4

Update to Android O preview 2

424e1bd

* Update support library to beta1; * Adapt to new foreground service policy; * Add a separate notification channel for NAT service; * Adapt to `findViewById` method signature changes. Possible issues: NAT notification will possibly not hide in lockscreen.

Mygod mentioned this pull request May 18, 2017

Can not run on Android 8.0 beta shadowsocks/kcptun-android#19

Closed

madeye added 3 commits May 26, 2017 18:01

Fix a crash caused by new background limit on Android O

574f80a

Roll back to Google's barcode scanner

1e750e4

Add back internal QR scanner. #1273

49e30e7

Mygod added 2 commits July 15, 2017 01:52

Use startService calls instead of AIDL to start services

143afb0

Because our data store is process-safe, we can remove the `use` function entirely and move more components to :bg process.

Update shortcut APIs

9c36f84

Mygod force-pushed the o-preview branch from 920082f to 9c36f84 Compare July 14, 2017 18:10

Mygod requested a review from madeye July 15, 2017 02:39

Implement adaptive icons

e1ee535

Mygod and others added 4 commits July 16, 2017 15:36

Opt-in for safe browsing

422924f

Opt out of cleartext traffic

ac28b83

Fix a crash in RunnerActivity

6978b92

Bump version

5549dfd

madeye added 2 commits July 19, 2017 09:16

Enlarge the text size of number picker

d701fb4

Fix a crash caused by evernote/android-job

d8179b5

madeye approved these changes Jul 19, 2017

View reviewed changes

madeye merged commit f950037 into develop Jul 19, 2017

Mygod deleted the o-preview branch September 3, 2017 22:28

Mygod mentioned this pull request Dec 23, 2017

Design improvements #1520

Closed

bannedbook pushed a commit to bannedbook/SpeedUp.VPN that referenced this pull request Dec 25, 2019

Merge pull request shadowsocks#1258 from shadowsocks/o-preview

3ddf747

Support for Android O preview

Support for Android O preview #1258

Support for Android O preview #1258

Conversation

Mygod commented May 18, 2017 • edited Loading

TODO

Mygod commented May 18, 2017

madeye commented May 18, 2017

Mygod commented May 18, 2017

madeye commented May 18, 2017

madeye commented May 18, 2017

madeye commented May 18, 2017

Mygod commented May 18, 2017

madeye commented May 18, 2017

madeye commented May 18, 2017

madeye commented May 18, 2017

Mygod commented May 18, 2017

Mygod commented May 18, 2017

Mygod commented May 18, 2017

madeye commented May 19, 2017

Mygod commented May 19, 2017 via email

madeye commented May 19, 2017

Mygod commented May 19, 2017

Mygod commented May 22, 2017

madeye commented May 22, 2017

madeye commented May 22, 2017

madeye commented May 22, 2017

Mygod commented May 22, 2017

madeye commented Jul 15, 2017

madeye commented Jul 15, 2017 • edited Loading

madeye commented Jul 15, 2017

Mygod commented Jul 16, 2017

Mygod commented Jul 16, 2017

Mygod commented Jul 16, 2017

Mygod commented Jul 16, 2017

madeye commented Jul 16, 2017

madeye commented Jul 16, 2017 • edited Loading

madeye commented Jul 16, 2017

madeye commented Jul 19, 2017

madeye commented Jul 19, 2017

Mygod commented Oct 28, 2017 • edited Loading

Mygod commented Jun 15, 2019

Mygod commented May 18, 2017 •

edited

Loading

madeye commented Jul 15, 2017 •

edited

Loading

madeye commented Jul 16, 2017 •

edited

Loading

Mygod commented Oct 28, 2017 •

edited

Loading