Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for new versions of magic_enum + cleanup #1419

Closed
wants to merge 1 commit into from

Conversation

Xphalnos
Copy link
Contributor

Since this commit Neargye/magic_enum#374, the latest version of magic_enum requires changes in externals/CMakeLists.txt.
I took the opportunity to put the dependencies back in alphabetical order.

@abouvier
Copy link
Contributor

The real fix is to use #include <magic_enum/magic_enum.hpp> instead of #include <magic_enum.hpp>, and exclude the current release with find_package(magic_enum 0.9.7 CONFIG).

@Xphalnos
Copy link
Contributor Author

The real fix is to use #include <magic_enum/magic_enum.hpp> instead of #include <magic_enum.hpp>, and exclude the current release with find_package(magic_enum 0.9.7 CONFIG).

However, the latest version is 0.9.6.

@abouvier
Copy link
Contributor

abouvier commented Oct 20, 2024

However, the latest version is 0.9.6.

That's why if you update the submodule and use an unreleased commit, then you need to require the next version, because the current one will not work with the change.

@Xphalnos Xphalnos closed this Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants