Skip to content

Commit

Permalink
Add banner role to logo container in sidebar header
Browse files Browse the repository at this point in the history
All page content must be contained by landmarks: https://dequeuniversity.com/rules/axe/4.1/region
  • Loading branch information
barrymcgee committed Jan 8, 2021
1 parent d4d7017 commit b46f447
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion includes/header.html
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

<header class="container-xl px-3 px-md-6 pt-3 pb-2 position-relative d-flex flex-justify-between width-full {% if error == '404' %} d-md-none {% endif %}">

<div class="d-flex flex-items-center d-lg-none" style="z-index: 3;" id="github-logo-mobile">
<div class="d-flex flex-items-center d-lg-none" style="z-index: 3;" id="github-logo-mobile" role="banner">
<a href="/{{ currentLanguage }}" aria-hidden="true" tabindex="-1">
{% octicon "mark-github" height="32" class="text-black" %}
</a>
Expand Down
2 changes: 1 addition & 1 deletion includes/sidebar.html
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<!-- product > category > maptopic > article -->
<div class="sidebar d-none d-lg-block">

<div class="d-flex flex-items-center p-4 position-sticky top-0 sidebar-background-color" style="z-index: 3;" id="github-logo">
<div class="d-flex flex-items-center p-4 position-sticky top-0 sidebar-background-color" style="z-index: 3;" id="github-logo" role="banner">
<a href="/{{ currentLanguage }}" class="text-white" aria-hidden="true" tabindex="-1">
{% octicon "mark-github" height="32" %}
</a>
Expand Down

0 comments on commit b46f447

Please sign in to comment.