Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates rescript syntax in docs #120

Merged
merged 3 commits into from
Feb 15, 2024

Conversation

EthanBonsignori
Copy link

Hi there 👋

I was reading the docs and noticed some syntax was out of date so I made a few changes that do the following:

  1. replaces type wrappers using () with <> option('type) -> option<'type>
  2. changes form ppx extension syntax with from being wrapped in [] to wrapping with (): [%form ...]; -> %form(...)
  3. removes [] from wrapping attributes: [@react.component] -> @react.component
    and with args i.e. an input type: [field]: @field.async(mode: OnBlur) string,
  4. adds the rec keyword where missing to type examples that are followed by and type = ...

I took into account #119 and did not make the same changes they already did

@alex35mil
Copy link
Member

@EthanBonsignori Sorry, I missed your PR either. Thank you!

@alex35mil alex35mil reopened this Feb 15, 2024
@alex35mil alex35mil merged commit e60808d into shakacode:master Feb 15, 2024
3 of 4 checks passed
@EthanBonsignori EthanBonsignori deleted the update-docs branch February 15, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants