Skip to content

Update Shakapacker to 10.2.0 #771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
justin808 merged 5 commits into from
Jul 5, 2026
+152 −147
Merged

Update Shakapacker to 10.2.0 #771

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ec66fec
Update Shakapacker to 10.2.0
justin808 Jul 4, 2026
c6914c2
Stabilize destroy comment system spec
justin808 Jul 5, 2026
5cc95e3
Keep css-loader on compatible v6 line
justin808 Jul 5, 2026
8573a1b
Minimize Shakapacker lockfile refresh
justin808 Jul 5, 2026
937d7b5
Add Rspack dev server dependency
justin808 Jul 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ ruby "3.4.6"

gem "cpflow", "5.1.1", require: false
gem "react_on_rails_pro", "17.0.0.rc.6"
gem "shakapacker", "10.1.0"
gem "shakapacker", "10.2.0"

# Bundle edge Rails instead: gem "rails", github: "rails/rails"
gem "rails", "~> 8.1.2"
Expand Down
6 changes: 3 additions & 3 deletions Gemfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,7 +290,7 @@ GEM
nio4r (~> 2.0)
racc (1.8.1)
rack (3.2.6)
rack-proxy (0.8.2)
rack-proxy (0.8.3)
rack
rack-session (2.1.2)
base64 (>= 0.1.0)
Expand Down Expand Up @@ -446,7 +446,7 @@ GEM
websocket (~> 1.0)
semantic_range (3.1.1)
sexp_processor (4.17.1)
shakapacker (10.1.0)
shakapacker (10.2.0)
activesupport (>= 5.2)
package_json
rack-proxy (>= 0.6.1)
Expand Down Expand Up @@ -561,7 +561,7 @@ DEPENDENCIES
scss_lint
sdoc
selenium-webdriver (~> 4)
shakapacker (= 10.1.0)
shakapacker (= 10.2.0)
spring
spring-commands-rspec
stimulus-rails (~> 1.3)
Expand Down
13 changes: 7 additions & 6 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,15 +47,15 @@
"@rails/actioncable": "7.0.5",
"@rescript/core": "^0.5.0",
"@rescript/react": "^0.11.0",
"@rspack/cli": "2.0.0-beta.7",
"@rspack/core": "2.0.0-beta.7",
"@rspack/cli": "2.0.4",
Comment thread
justin808 marked this conversation as resolved.
"@rspack/core": "2.0.4",
Comment thread
justin808 marked this conversation as resolved.
"@swc/core": "^1.13.5",
"ajv": "^8.17.1",
"autoprefixer": "^10.4.14",
"axios": "^0.21.1",
"classnames": "^2.3.2",
"compression-webpack-plugin": "10.0.0",
"css-loader": "^6.7.3",
"css-loader": "^6.8.1",
"css-minimizer-webpack-plugin": "^5.0.1",
"es5-shim": "^4.6.7",
"estraverse": "^5.3.0",
Expand Down Expand Up @@ -100,7 +100,7 @@
"sass": "^1.58.3",
"sass-loader": "^13.3.2",
"sass-resources-loader": "^2.2.5",
"shakapacker": "10.1.0",
"shakapacker": "10.2.0",
Comment thread
justin808 marked this conversation as resolved.
"stimulus": "^3.0.1",
"style-loader": "^3.3.1",
"swc-loader": "^0.2.6",
Expand All @@ -116,7 +116,8 @@
"devDependencies": {
"@babel/eslint-parser": "^7.16.5",
"@babel/preset-react": "^7.18.6",
"@rspack/plugin-react-refresh": "1.6.1",
"@rspack/dev-server": "^2.0.4",
"@rspack/plugin-react-refresh": "2.0.0",
Comment thread
justin808 marked this conversation as resolved.
"@tailwindcss/typography": "^0.5.10",
"@testing-library/dom": "^10.4.1",
"@testing-library/jest-dom": "^6.9.1",
Expand Down Expand Up @@ -147,7 +148,7 @@
"react-refresh": "^0.14.0",
"react-transform-hmr": "^1.0.4",
"regenerator-runtime": "^0.13.11",
"rspack-manifest-plugin": "^5.1.0",
"rspack-manifest-plugin": "^5.2.2",
"typescript": "^5.1.3",
"webpack-dev-server": "^4.11.1"
},
Expand Down
1 change: 1 addition & 0 deletions spec/system/destroy_comment_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@

click_link "New Comment"
submit_form(name: comment.author, text: comment.text)
expect(page).to have_css("#notice", text: "Comment was successfully created.")
click_link "Back"

accept_confirm do
Expand Down
Loading
Loading