chore: add agent workflow seam#778
Conversation
🚀 Quick Review App CommandsWelcome! Here are the commands you can use in this PR:
|
|
Warning Review limit reached
Next review available in: 11 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. WalkthroughAdded repository-level agent workflow configuration, standardized command entrypoints for setup, build, lint, test, and validation, trusted GitHub actor allowlists, renderer lifecycle handling, and documentation describing command and policy resolution. ChangesAgent workflow setup
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related issues
Sequence Diagram(s)sequenceDiagram
participant TestScript
participant Renderer
participant CIPipeline
TestScript->>Renderer: Check port 3800
TestScript->>Renderer: Start renderer when unavailable
Renderer-->>TestScript: Port becomes ready
TestScript->>CIPipeline: Run bin/ci
TestScript->>Renderer: Stop spawned renderer on exit
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
Review SummarySmall, additive PR that adds a repo-side "agent workflow seam" ( Overview
Code quality
Issues found (posted inline)
Security
Test coverage
Overall this is low-risk, well-structured plumbing; the main actionable feedback is closing the gap between what the seam claims to validate/test and what actually gets exercised (Ruby-only, and only functional after a build step the seam doesn't provide). |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Greptile SummaryThis PR adds the repository seam used by shared agent workflows. The main changes are:
Confidence Score: 4/5The shared test entrypoint needs a fix before merging.
.agents/bin/test, .agents/bin/README.md Important Files Changed
Reviews (1): Last reviewed commit: "chore: add agent workflow seam" | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cd56081da8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Review: chore: add agent workflow seamOverviewAdds a small, self-contained "agent workflow seam": Code quality
Security
Test coverage
Overall this is low-risk, well-scoped config addition. The two inline notes are minor efficiency/consistency nits, not blockers. |
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
.agents/bin/test (1)
5-5: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low valueConsider forwarding
"$@"for consistency with other entrypoints.Unlike
validateandlint, this script doesn't forward CLI arguments to the underlying command. Users who expect to pass specific test files (e.g.,.agents/bin/test spec/models/foo_spec.rb) will be surprised. The line-range change details confirm this is intentional, but ifbin/ciaccepts args, forwarding them would improve uniformity across entrypoints.♻️ Optional: forward arguments
-exec bin/conductor-exec bin/ci +exec bin/conductor-exec bin/ci "$@"🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.agents/bin/test at line 5, Update the .agents/bin/test entrypoint’s exec invocation to forward all received CLI arguments to bin/ci via "$@". Preserve the existing command and execution behavior while allowing callers to target specific test files or options.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.agents/bin/build:
- Around line 6-8: Update the build script to remove the standalone
react_on_rails:generate_packs and yarn res:build commands, leaving the yarn
build:test "$@" invocation to perform those steps without duplication.
---
Nitpick comments:
In @.agents/bin/test:
- Line 5: Update the .agents/bin/test entrypoint’s exec invocation to forward
all received CLI arguments to bin/ci via "$@". Preserve the existing command and
execution behavior while allowing callers to target specific test files or
options.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 7505ee2b-c169-48aa-b844-103125e6a025
📒 Files selected for processing (6)
.agents/bin/README.md.agents/bin/build.agents/bin/lint.agents/bin/setup.agents/bin/test.agents/bin/validate
✅ Files skipped from review due to trivial changes (1)
- .agents/bin/README.md
QA Evidence
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cc4dea03df
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Review SummaryThis PR adds a small, self-contained "agent workflow seam": Verified
Findings
RiskLow — this PR only adds metadata/config and thin wrapper scripts; it doesn't touch application code, and the author's own validation ( |
QA Evidence
|
Address-review summaryScan scope: full history through current head Mattered
Optional
Skipped
All current review threads were replied to and resolved. The final-head QA evidence is recorded separately in the PR discussion. Next default scan starts after this comment. Say |
QA Evidence
|
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
.agents/bin/test (1)
9-18: 🩺 Stability & Availability | 🔵 Trivial | 💤 Low valueConsider SIGKILL escalation in cleanup.
cleanup_renderersends SIGTERM and thenwaits indefinitely. If the renderer doesn't shut down gracefully, the script hangs on exit. A short timeout followed by SIGKILL would prevent this.♻️ Optional refactor
cleanup_renderer() { local status=$? if [[ "$renderer_started" == true ]] && kill -0 "$renderer_pid" 2>/dev/null; then kill "$renderer_pid" 2>/dev/null || true - wait "$renderer_pid" 2>/dev/null || true + local i + for i in $(seq 1 10); do + kill -0 "$renderer_pid" 2>/dev/null || break + sleep 0.5 + done + if kill -0 "$renderer_pid" 2>/dev/null; then + kill -9 "$renderer_pid" 2>/dev/null || true + wait "$renderer_pid" 2>/dev/null || true + fi fi exit "$status" }🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.agents/bin/test around lines 9 - 18, Update cleanup_renderer to wait only briefly after sending SIGTERM, then send SIGKILL to renderer_pid if the process is still running before waiting for it. Preserve the existing status capture and cleanup behavior, including avoiding errors when the renderer has already exited.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.agents/bin/test:
- Around line 22-45: Update the renderer startup and readiness checks in the
test script to derive the port from RENDERER_PORT, defaulting to 3800 when
unset, instead of hardcoding 3800. Use the same derived port for all nc checks
and status messages, while preserving the existing renderer startup and timeout
behavior.
---
Nitpick comments:
In @.agents/bin/test:
- Around line 9-18: Update cleanup_renderer to wait only briefly after sending
SIGTERM, then send SIGKILL to renderer_pid if the process is still running
before waiting for it. Preserve the existing status capture and cleanup
behavior, including avoiding errors when the renderer has already exited.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ReviewOverviewAdds a "seam" so shared ShakaCode agent-workflow skills can discover this repo's commands: Code quality
Security
Testing
Suggestions
Overall this is a low-risk, well-structured addition — no correctness or security blockers found. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 74056737d3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Review: chore: add agent workflow seamOverviewThis PR adds a self-describing "agent workflow seam" so shared/portable agent tooling (from
This is infra/metadata only — no application code paths are touched, and the scope is well contained. Code quality
Issues found (posted inline)
Other notes (not blocking)
Overall this is a low-risk, well-scoped addition. The two inline notes are minor polish items, not blockers. |
QA Evidence
|
ReviewOverviewAdds a shared "agent workflow seam" so external agent-workflow tooling can discover this repo's setup/validate/test/lint/build commands and policy without hardcoding logic per-repo: Code quality
Issues found (posted inline)
Other notes
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4ee4c0752e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
✅ Review App DeletedReview app for PR #778 is deleted |
1 participant
Summary
Shared ShakaCode workflows can now resolve this repository's validation and test commands, policy, trusted-actor defaults, and
masterbase branch without copying workflow logic into the repo.Validation
agent-workflow-seam-doctor --shared "$HOME/src/agent-workflows"— passed.agents/bin/validate— passed (57 files inspected; no RuboCop offenses).agents/bin/test— attempted; 47 specs fail because the checkout lacksssr-generated/server-bundle.js, a generated SSR artifact required by the existing system tests.Post-Deploy Monitoring & Validation
No additional operational monitoring required: this change only adds repository-local agent workflow metadata and command wrappers.
Summary by CodeRabbit
Documentation
Chores