Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update turbolinks.md #573

Merged
merged 1 commit into from
Oct 22, 2016
Merged

Update turbolinks.md #573

merged 1 commit into from
Oct 22, 2016

Conversation

justin808
Copy link
Member

@justin808 justin808 commented Oct 22, 2016

This change is Reviewable

@justin808
Copy link
Member Author

@Judahmeek?

@justin808
Copy link
Member Author

@robwise, @alexfedoseev, @dzirtusss Please comment.

@alex35mil
Copy link
Member

@justin808 LGTM

@Judahmeek
Copy link
Contributor

Nice! Reading turbolinks/turbolinks-classic#658 was pretty awesome.

@justin808 justin808 merged commit d972ca4 into master Oct 22, 2016
@dzirtusss
Copy link
Contributor

@justin808 @alexfedoseev @Judahmeek @robwise LGTM, and just for further info, some issues I had with Turbolinks5 worth mentioning:

  • CFRS tokens need thorough check with Turbolinks5. Turbolinks5 do change head element by JavaScript (not only body) on page change with correct csrf meta tag, but it was something with the way it was taken from head when several windows were opened, that our specs were not all passing. I didn't look details however, may be it is app code related, not library code. Anyway it may need additional check because there is cfrs helper in ReactOnRails and it need to work with Turbolinks5.
  • Turbolinks5 send requests without Accept: */* in header, only exact like Accept: text/html which makes Rails behave a bit specifically compared to normal and do mime-parsing (which is skipped by desing when Rails see */*). In my case it was triggering :mjml parser not found error, as example. For some more details on Rails and */* can read http://blog.bigbinary.com/2010/11/23/mime-type-resolution-in-rails.html
  • As noted above there should be no names conflict and all components need to be loaded and registered with first page load

@justin808 justin808 deleted the justin808-turbolinks branch January 14, 2017 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants