Skip to content

Prepare 19.2.1-rc.0 release#177

Merged
justin808 merged 2 commits into
mainfrom
jg-codex/changelog-19.3.0-rc.0
Jul 6, 2026
Merged

Prepare 19.2.1-rc.0 release#177
justin808 merged 2 commits into
mainfrom
jg-codex/changelog-19.3.0-rc.0

Conversation

@justin808

@justin808 justin808 commented Jul 6, 2026

Copy link
Copy Markdown
Member

Summary

  • Stamps CHANGELOG.md for 19.2.1-rc.0 using the existing Unreleased entries.
  • Bumps package.json to 19.2.1-rc.0 and keeps the release-policy test on the React 19.2 runtime package line.
  • Adds the 19.2.0...19.2.1-rc.0 compare link.

Classification sweep

Range: 19.2.0..origin/main

PR Result Category Reason
#138 no-entry release-process GitHub Actions dependency updates only.
#144 entry-needed product code Adds opt-in static RSC island diagnostics.
#143 entry-needed product code Adds RSC resource hint helpers and expanded server types.
#139 no-entry internal Package dependency metadata/lockfile update without package behavior change.
#151 entry-needed product code Restores CSS hints for CSS-only split chunks.
#164 entry-needed product code Refreshes client references during watch rebuilds.
#152 entry-needed perf-reliability Skips unused rspack diagnostics CSS work.
#165 entry-needed product code Installs the rspack splitChunks guard after defaults.
#166 entry-needed product code Scopes rspack diagnostics CSS to owner chunks.
#163 no-entry release-process Dependabot auto-merge workflow hardening only.
#167 entry-needed perf-reliability Preserves rspack incremental caching while keeping discovery behavior.
#168 entry-needed product code Scopes rspack runtime injection state by compiler.
#169 no-entry release-process Claude review workflow token wiring only.
#170 no-entry internal Release documentation only.
#140 entry-needed product code Adds Rspack 2 manifest compatibility fixes.
#173 no-entry internal Static-island documentation only.
#174 no-entry internal README/system-spec transport documentation only.
#171 entry-needed product code Fixes Webpack manifest path/publicPath parity gaps.
#175 no-entry internal Agent workflow/docs maintenance only.
#172 entry-needed product code Fixes Rspack manifest runtime parity gaps.

Verification

  • yarn build
  • yarn jest tests/package-runtime-policy.test.ts
  • yarn test
  • yarn release:check metadata/tag/npm checks passed for 19.2.1-rc.0; the command then failed as expected because it must run from a clean main checkout after this PR merges.

After this PR merges, run yarn release:check from clean synced main and dispatch the Release package workflow command printed by that check.

Summary by CodeRabbit

  • Documentation

    • Added release notes for 19.2.1-rc.0, including updated comparison links.
  • Chores

    • Bumped the package version to 19.2.1-rc.0.
  • Tests

    • Updated release-line validation to recognize 19.2.1 and related release-candidate versions.

@coderabbitai

coderabbitai Bot commented Jul 6, 2026

Copy link
Copy Markdown

Review Change Stack

Walkthrough

The package version is bumped from 19.2.0 to 19.2.1-rc.0 in package.json, CHANGELOG.md is updated with a new dated release entry replacing the Unreleased section and its compare link, and the runtime policy test's version regex and description are updated to match.

Changes

Release version stamp

Layer / File(s) Summary
Version bump and changelog stamping
package.json, CHANGELOG.md, tests/package-runtime-policy.test.ts
Version bumped to 19.2.1-rc.0, changelog heading/compare link updated accordingly, and the runtime policy test's regex and description updated to validate the new version line.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Possibly related PRs

  • shakacode/react_on_rails_rsc#107: Both PRs update CHANGELOG.md to replace the Unreleased section with a stamped release entry and update the bottom compare links.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately and concisely summarizes the release prep changes for 19.2.1-rc.0.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch jg-codex/changelog-19.3.0-rc.0

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@greptile-apps

greptile-apps Bot commented Jul 6, 2026

Copy link
Copy Markdown

Greptile Summary

This PR prepares the 19.3.0-rc.0 release by stamping the CHANGELOG, bumping package.json, and updating the release-policy test to validate the new version line.

  • CHANGELOG.md: [Unreleased] renamed to [19.3.0-rc.0] - 2026-07-05 and the compare link updated from HEAD to the specific RC tag.
  • package.json: Version bumped from 19.2.0 to 19.3.0-rc.0.
  • tests/package-runtime-policy.test.ts: Version regex and description updated to 19.3.0; the describe block label was not updated and still reads '19.2 runtime release policy'.

Confidence Score: 5/5

This is a straightforward release-stamp change — CHANGELOG header rename, a single version field bump, and matching test updates — with no logic changes and only a minor label inconsistency in the test suite.

All three files make exactly the changes described in the PR: the CHANGELOG and package.json are stamped correctly, and the test regex now targets 19.3.0. The only gap is the stale describe block label, which does not affect test correctness or the release itself.

tests/package-runtime-policy.test.ts — the describe block label still says '19.2' while the test body now validates '19.3.0'.

Important Files Changed

Filename Overview
CHANGELOG.md Renames [Unreleased] header to [19.3.0-rc.0] - 2026-07-05 and updates the compare link from HEAD to the specific RC tag; no issues found.
package.json Single version bump from 19.2.0 to 19.3.0-rc.0; no other fields changed.
tests/package-runtime-policy.test.ts Regex and comments updated to the 19.3.0 release line, but the describe block label still reads '19.2 runtime release policy'.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[CHANGELOG.md
'Unreleased' → '19.3.0-rc.0 - 2026-07-05'] --> D[Release 19.3.0-rc.0]
    B[package.json
'19.2.0' → '19.3.0-rc.0'] --> D
    C[tests/package-runtime-policy.test.ts
regex updated to 19.3.0 line] --> D
    D --> E[yarn release:check passes]
    E --> F[Dispatch 'Release package' workflow]
Loading
%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
flowchart TD
    A[CHANGELOG.md
'Unreleased' → '19.3.0-rc.0 - 2026-07-05'] --> D[Release 19.3.0-rc.0]
    B[package.json
'19.2.0' → '19.3.0-rc.0'] --> D
    C[tests/package-runtime-policy.test.ts
regex updated to 19.3.0 line] --> D
    D --> E[yarn release:check passes]
    E --> F[Dispatch 'Release package' workflow]
Loading

Reviews (1): Last reviewed commit: "Update CHANGELOG.md and package version ..." | Re-trigger Greptile

Comment thread tests/package-runtime-policy.test.ts

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 891ecbd068

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread package.json Outdated
Comment thread package.json Outdated
@claude

claude Bot commented Jul 6, 2026

Copy link
Copy Markdown

Review

This PR is a small, mechanical release-prep change: stamps CHANGELOG.md's ## [Unreleased] section as ## [19.3.0-rc.0], bumps package.json to 19.3.0-rc.0, and updates the release-policy test regex to match. The changelog content itself and the compare-link format are correct and consistent with prior releases.

Finding (versioning policy): package.json:3 — the version bump is a package minor bump (19.2.0 → 19.3.0-rc.0) with no accompanying React runtime change. Per docs/versioning.md, the package major.minor is supposed to track the React runtime major.minor line ("Do not move a package line to a different React runtime minor without opening a new package minor line"). This PR's package.json diff touches only the version field — peerDependencies (react/react-dom ^19.2.7) and dependencies["react-server-dom-webpack"] (~19.2.7) are unchanged, and none of the stamped changelog entries (resource-hint helpers, client-reference diagnostics, rspack/webpack manifest fixes) bump the Flight runtime. Since the runtime stays on the 19.2 line, this release should likely stay a 19.2.x prerelease (e.g. 19.2.1-rc.0) rather than moving to 19.3.0-rc.0, unless there's an intentional policy exception for this release that should be called out in the PR description. Left as an inline comment on package.json.

Minor nit (non-blocking): tests/package-runtime-policy.test.ts — the describe('19.2 runtime release policy', ...) block name is now stale relative to the 19.3.0 version regex it asserts. Not functionally wrong (the test still checks whatever package.json says), just a naming drift worth fixing in the same pass or a follow-up.

No security, correctness, or performance concerns beyond the versioning-policy question above — the diff is otherwise a straightforward, low-risk changelog/version stamp.

@justin808 justin808 changed the title Prepare 19.3.0-rc.0 release Prepare 19.2.1-rc.0 release Jul 6, 2026
@justin808

Copy link
Copy Markdown
Member Author

Address-review summary

Scan scope: full PR history; no previous address-review summary cutoff was present.

Mattered

  • Addressed the package-line blocker from Codex/Claude by retargeting the release from 19.3.0-rc.0 to 19.2.1-rc.0 in 2ef5043, keeping the package major/minor aligned with the React 19.2 runtime dependencies.

Optional

  • Addressed the stale test-label nit by retargeting to 19.2.1-rc.0; describe('19.2 runtime release policy') now matches the runtime line again, and the test name/assertion pin the 19.2.1 release line.

Skipped

  • CodeRabbit rate-limit/status output and bot summary-only comments were not actionable.

Validation:

  • yarn jest tests/package-runtime-policy.test.ts
  • yarn test
  • yarn build
  • yarn release:check metadata/tag/npm checks passed for 19.2.1-rc.0; it then stopped as expected because release readiness must be checked from clean main after this PR merges.

Next default scan starts after this comment. Say check all reviews to rescan the full PR.

@claude

claude Bot commented Jul 6, 2026

Copy link
Copy Markdown

Review

This PR is a mechanical release-stamping change: it renames the CHANGELOG [Unreleased] header to [19.2.1-rc.0] - 2026-07-05, adds the corresponding compare-link, bumps package.json to 19.2.1-rc.0, and updates tests/package-runtime-policy.test.ts's regex/comment to match the new release line.

Verified:

No correctness, security, or performance issues found — this is a clean, low-risk changelog/version stamp. One very minor, non-blocking nit: the stamped CHANGELOG date is 2026-07-05 while the PR's commits are dated 2026-07-06; worth double-checking that's the intended release date before merging, though release:check doesn't enforce this and it has no functional effect.

@justin808 justin808 merged commit 9fae9c7 into main Jul 6, 2026
18 checks passed
justin808 added a commit that referenced this pull request Jul 7, 2026
…lient-refs

* origin/main:
  Organize package docs as internal (#178)
  Prepare 19.2.1-rc.0 release (#177)

# Conflicts:
#	docs/rsc-static-islands-diagnostics.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant