Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase code coverage #23

Merged
merged 3 commits into from
Jul 31, 2024
Merged

Increase code coverage #23

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ae3fdc8
Add ruby version
pedrinlopes Jul 31, 2024
4056859
Rspec for SkipTask
pedrinlopes Jul 31, 2024
b2b3891
Fix cop rules
pedrinlopes Jul 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .ruby-version
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
3.3.4
20 changes: 20 additions & 0 deletions spec/non_rails/uber_task/task_skipped_on_error_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
describe UberTask::SkipTask do
it 'Skips the task on a error' do
task_skipped_after_exception = false

UberTask.run do
UberTask.on_subtask_error do |_task, _event, err|
if err.message == 'Some error'
task_skipped_after_exception = true
UberTask.skip(reason: err)
end
end

UberTask.run do
raise 'Some error' if task_skipped_after_exception == false
end
end
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simplify the condition.

The condition if task_skipped_after_exception == false can be simplified to unless task_skipped_after_exception.

-        raise 'Some error' if task_skipped_after_exception == false
+        raise 'Some error' unless task_skipped_after_exception
Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
UberTask.run do
UberTask.on_subtask_error do |_task, _event, err|
if err.message == 'Some error'
task_skipped_after_exception = true
UberTask.skip(reason: err)
end
end
UberTask.run do
raise 'Some error' if task_skipped_after_exception == false
end
end
UberTask.run do
UberTask.on_subtask_error do |_task, _event, err|
if err.message == 'Some error'
task_skipped_after_exception = true
UberTask.skip(reason: err)
end
end
UberTask.run do
raise 'Some error' unless task_skipped_after_exception
end
end


expect(task_skipped_after_exception).to be(true)
end
end
Loading