Added specs for UberTask #on_retry and #on_report methods #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
borela
approved these changes
Dec 21, 2023
| "Added some logs" | ||
| end | ||
|
|
||
| expect(result.call).to eq("Added some logs") |
There was a problem hiding this comment.
We need to update the on_report to always return nil, the returned value was not intentional.
we need to check that the block was added to the task's handlers (you can see here that tasks are expected to have a handlers attribute).
|
|
||
| expect(task.handlers[:retry]).to be_nil | ||
| expect(task.retry_info.report).to be false | ||
| expect(task.retry_info.wait).to eq(12) |
There was a problem hiding this comment.
We also need to update the on_retry method to always return nil. The returned value was not intentional.
| describe '.on_report' do | ||
| context 'when no block is passed' do | ||
| it 'returns nil' do | ||
| described_class.run do |task| |
There was a problem hiding this comment.
the |task| can be removed here since it is not used in the test.
|
|
||
| described_class.run do |task| | ||
| described_class.on_retry(report: true, wait: 30) do | ||
| expected_block |
There was a problem hiding this comment.
You can simplify this test by returning a random number like 42 and avoiding the expected_block hash.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #5