-
-
Notifications
You must be signed in to change notification settings - Fork 386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Support for git repository #707
Conversation
@wasikuss when are you planning to complete this PR. :) |
Probably tomorrow. I've download implemented but it doesn't trigger update ( no new extensions installed, etc. ). I'm searching why it happens. |
sure, i have updated the todo for this pr also. So we both are on same page for this Feature. |
I have some questions:
|
|
Can we set any deadline (whatever that is feasible for you) for this paid PR ? |
I will push changes until tomorrow, sorry for taking so long. I'm only need to finish github/gitlab integration, so if there will be no additional comments to PR then tomorrow it will be done. |
There are some bugs in this PR and I'll try fix them as soon as possible. Main objectives has been achieved but I've found additional special cases. |
Okay thats great. You might need to add wiki in Wiki section. Make sure to ask user to select from Gist or Git repository on installing and setting up first time. Once it is completed from your side - I will start a review, after publishing i will assign you all the upcoming issues [ limited to the requirement locked down above] :) |
I had a break of coding last week and now I'm back. Only some UI changes left so I will push changes in couple of days. After that, we all can test if all works as should. |
any update on this? |
I'll be closing this PR in this month end ( after 9 days ). If you will be able to complete it by then, it will be merged, else I will be assigning bounty and feature to someone else. |
Short description of what this resolves:
This PR introduce support for git repository for settings. It allows to push settings to remote repo with opt-out (uncheck option in settings)
Changes proposed in this pull request:
Slightly changed flow of gist. Generated files are saved to disk and then committed to gist/repo. After this gist flow can be simplified - no template is required (
GIST_JSON_EMPTY
).Fixes: #413
How Has This Been Tested?
Tested locally and on clean OS. No git installed, no git configs, etc.
Checklist:
TODO:
git pull
forcefully.git push
forcefully.master
andoffice
and keep the selected profile / branch in Sync Global Settings and download/ upload to that branch.