fix: vite build binding not found error #90
Conversation
| @@ -24,7 +24,7 @@ | |||
| }, | |||
| "engines": { | |||
| "node": ">=16.0.0", | |||
| "npm": "^7.0.0" | |||
| "npm": ">=7.0.0" | |||
There was a problem hiding this comment.
Why did you change this? Any particular reason?
There was a problem hiding this comment.
I'm using node 18 with npm 9 and this was giving me warnings.
For the lock file, maybe its because I'm using npm 9? 🤔
There was a problem hiding this comment.
We should probably build and run the tests in the CI to ensure pull requests are working at a minimum level
There was a problem hiding this comment.
Tests have been broken for a while, I decided to park tests while the architecture was changing so much 🙃 all good I'd say the biggest descrepency here with the lock file, is that you most likely followed step 1 in the link I sent? If you had removed the lock file then run npm I it explains the diff here :)
There was a problem hiding this comment.
Yeah I added some new dev packages to ensure it works properly for everyone.
I don't think a big change in the lock file is an issue, it is actually expected when you add new packages :)
I've been testing with linked package on my test dashboard and everything seems to be working just fine.
Need anything changed before we merge this?
There was a problem hiding this comment.
Sweet, and nope no changes, just need some time to check it out and test it on my machine to ensure it works for me 😅
There was a problem hiding this comment.
Awesome, keep me posted :)
closes #89